Skip to content

Commit ef5ae35

Browse files
authored
[test] Remove unnecessary bigint flags. NFC (emscripten-core#24815)
Split out from emscripten-core#24808
1 parent 234ee52 commit ef5ae35

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

test/test_core.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -602,9 +602,7 @@ def test_i64_varargs(self):
602602
@no_wasm2js('wasm_bigint')
603603
@requires_node
604604
def test_i64_invoke_bigint(self):
605-
self.set_setting('WASM_BIGINT')
606605
self.cflags += ['-fexceptions']
607-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
608606
self.do_core_test('test_i64_invoke_bigint.cpp')
609607

610608
@only_wasm2js('tests va_arg()')
@@ -2073,7 +2071,6 @@ def test_em_js(self, args, force_c):
20732071
def test_em_js_i64(self):
20742072
err = self.expect_fail([EMCC, '-Werror', '-sWASM_BIGINT=0', test_file('core/test_em_js_i64.c')])
20752073
self.assertContained('emcc: error: using 64-bit arguments in EM_JS function without WASM_BIGINT is not yet fully supported: `foo`', err)
2076-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
20772074
self.do_core_test('test_em_js_i64.c')
20782075

20792076
def test_em_js_address_taken(self):
@@ -7646,19 +7643,15 @@ def test_embind_dynamic_initialization(self):
76467643
'safe_heap': (True,),
76477644
})
76487645
def test_embind_i64_val(self, safe_heap):
7649-
self.set_setting('WASM_BIGINT')
76507646
if safe_heap and '-fsanitize=address' in self.cflags:
76517647
self.skipTest('asan does not work with SAFE_HEAP')
76527648
self.set_setting('SAFE_HEAP', safe_heap)
76537649
self.cflags += ['-lembind']
7654-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
76557650
self.do_run_in_out_file_test('embind/test_i64_val.cpp', assert_identical=True)
76567651

76577652
@no_wasm2js('wasm_bigint')
76587653
def test_embind_i64_binding(self):
7659-
self.set_setting('WASM_BIGINT')
76607654
self.cflags += ['-lembind', '--js-library', test_file('embind/test_i64_binding.js')]
7661-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
76627655
self.do_run_in_out_file_test('embind/test_i64_binding.cpp', assert_identical=True)
76637656

76647657
def test_embind_no_rtti(self):
@@ -9936,8 +9929,7 @@ def setUp(self):
99369929
require_wasm64=True)
99379930
# MEMORY64=2, or "lowered"
99389931
wasm64l = make_run('wasm64l', cflags=['-O1', '-Wno-experimental', '--profiling-funcs'],
9939-
settings={'MEMORY64': 2},
9940-
init=lambda self: shared.node_bigint_flags(self.get_nodejs()))
9932+
settings={'MEMORY64': 2})
99419933

99429934
lto0 = make_run('lto0', cflags=['-flto', '-O0'])
99439935
lto1 = make_run('lto1', cflags=['-flto', '-O1'])
@@ -9973,9 +9965,6 @@ def setUp(self):
99739965
core2s = make_run('core2s', cflags=['-O2'], settings={'SAFE_HEAP': 1})
99749966
core2ss = make_run('core2ss', cflags=['-O2'], settings={'STACK_OVERFLOW_CHECK': 2})
99759967

9976-
bigint = make_run('bigint', cflags=['--profiling-funcs'], settings={'WASM_BIGINT': 1},
9977-
init=lambda self: shared.node_bigint_flags(self.get_nodejs()))
9978-
99799968
esm_integration = make_run('esm_integration', init=lambda self: self.setup_esm_integration())
99809969
instance = make_run('instance', cflags=['-Wno-experimental'], settings={'MODULARIZE': 'instance'})
99819970

test/test_other.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8512,7 +8512,6 @@ def test_i64_return_value(self, args, bind_js):
85128512
''')
85138513

85148514
# Run the test and confirm the output is as expected.
8515-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
85168515
out = self.run_js('testrun.js')
85178516
self.assertContained('''\
85188517
input = 0xaabbccdd11223344
@@ -15320,7 +15319,6 @@ def test_missing_struct_info(self):
1532015319
def run_wasi_test_suite_test(self, name):
1532115320
if not os.path.exists(path_from_root('test/third_party/wasi-test-suite')):
1532215321
self.fail('wasi-testsuite not found; run `git submodule update --init`')
15323-
self.node_args += shared.node_bigint_flags(self.get_nodejs())
1532415322
wasm = path_from_root('test', 'third_party', 'wasi-test-suite', name + '.wasm')
1532515323
with open(path_from_root('test', 'third_party', 'wasi-test-suite', name + '.json')) as f:
1532615324
config = json.load(f)

0 commit comments

Comments
 (0)