fix(rules): require concurrent index creation (#157)

We weren't checking what type of drop was happening, so any drop stmt that
wasn't marked concurrent was causing an error.

#151
#152
#156

Author: sbdchd

Cargo.lock

@@ -1,6 +1,6 @@
 use crate::rules::utils::tables_created_in_transaction;
 use crate::violations::{RuleViolation, RuleViolationKind};
-use squawk_parser::ast::{RelationKind, RootStmt, Stmt};
+use squawk_parser::ast::{ObjectType, RelationKind, RootStmt, Stmt};
 
 #[must_use]
 pub fn require_concurrent_index_creation(tree: &[RootStmt]) -> Vec<RuleViolation> {
@@ -19,11 +19,13 @@ pub fn require_concurrent_index_creation(tree: &[RootStmt]) -> Vec<RuleViolation
                     ));
                 }
             }
-            Stmt::DropStmt(stmt) if !stmt.concurrent => errs.push(RuleViolation::new(
-                RuleViolationKind::RequireConcurrentIndexCreation,
-                raw_stmt.into(),
-                None,
-            )),
+            Stmt::DropStmt(stmt) if !stmt.concurrent && stmt.remove_type == ObjectType::Index => {
+                errs.push(RuleViolation::new(
+                    RuleViolationKind::RequireConcurrentIndexCreation,
+                    raw_stmt.into(),
+                    None,
+                ))
+            }
             _ => continue,
         }
     }
@@ -76,4 +78,28 @@ mod test_rules {
   "#;
         assert_eq!(check_sql(ok_sql, &[]), Ok(vec![]));
     }
+
+    #[test]
+    fn regression_false_positive_drop_type() {
+        let sql = r#"
+  DROP TYPE IF EXISTS foo;
+  "#;
+        assert_eq!(check_sql(sql, &[]), Ok(vec![]));
+    }
+
+    #[test]
+    fn regression_false_positive_drop_table() {
+        let sql = r#"
+  DROP TABLE IF EXISTS some_table;
+  "#;
+        assert_eq!(check_sql(sql, &[]), Ok(vec![]));
+    }
+
+    #[test]
+    fn regression_false_positive_drop_trigger() {
+        let sql = r#"
+  DROP TRIGGER IF EXISTS trigger on foo_table;
+  "#;
+        assert_eq!(check_sql(sql, &[]), Ok(vec![]));
+    }
 }