Skip to content

Commit 5c59a0f

Browse files
authored
vscode: update readme (#580)
disable definition provider for now since it's not working
1 parent 7227e2b commit 5c59a0f

File tree

3 files changed

+28
-5
lines changed

3 files changed

+28
-5
lines changed

crates/squawk_server/src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ use lsp_server::{Connection, Message, Notification, Response};
55
use lsp_types::{
66
CodeDescription, Diagnostic, DiagnosticSeverity, DidChangeTextDocumentParams,
77
DidCloseTextDocumentParams, DidOpenTextDocumentParams, GotoDefinitionParams,
8-
GotoDefinitionResponse, InitializeParams, Location, OneOf, Position, PublishDiagnosticsParams,
9-
Range, ServerCapabilities, TextDocumentSyncCapability, TextDocumentSyncKind, Url,
8+
GotoDefinitionResponse, InitializeParams, Location, Position, PublishDiagnosticsParams, Range,
9+
ServerCapabilities, TextDocumentSyncCapability, TextDocumentSyncKind, Url,
1010
notification::{
1111
DidChangeTextDocument, DidCloseTextDocument, DidOpenTextDocument, Notification as _,
1212
PublishDiagnostics,
@@ -23,7 +23,7 @@ pub fn run() -> Result<()> {
2323

2424
let server_capabilities = serde_json::to_value(&ServerCapabilities {
2525
text_document_sync: Some(TextDocumentSyncCapability::Kind(TextDocumentSyncKind::FULL)),
26-
definition_provider: Some(OneOf::Left(true)),
26+
// definition_provider: Some(OneOf::Left(true)),
2727
..Default::default()
2828
})
2929
.unwrap();

squawk-vscode/README.md

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,31 @@
22

33
> Visual Studio Code support for Squawk
44
5-
## dev
5+
Surface SQL related lint errors directly in VSCode.
6+
7+
## Install
8+
9+
Install via the [VSCode marketplace](https://marketplace.visualstudio.com/items?itemName=sbdchd.squawk).
10+
11+
## Install
12+
13+
### From online marketplace
14+
15+
Open the [online marketplace listing](https://marketplace.visualstudio.com/items?itemName=sbdchd.squawk) for Squawk and click "Install". Follow the prompts to open VSCode and install Squawk.
16+
17+
### From VSCode
18+
19+
In VSCode, type `CMD`+`P`, run `Extensions: Install Extensions`, search for `sbdchd.squawk` and click install.
20+
21+
### From Github release
22+
23+
Download the extension package from the [latest Github release](https://github.com/sbdchd/squawk/releases/latest) and run `code --install-extension squawk-*.vsix`
24+
25+
### From source
26+
27+
With `vsce` installed from NPM (`npm install -g @vscode/vsce`), clone [this repo](https://github.com/sbdchd/vscode-squawk) and run `vsce package`. Install the resulting package with `code --install-extension squawk-*.vsix`
28+
29+
## Dev
630

731
Make sure you're on a vscode version >= the one defined in the `package.json`,
832
otherwise the extension development host won't load the extension.

squawk-vscode/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"engines": {
1414
"vscode": "^1.101.0"
1515
},
16-
"preview": true,
1716
"keywords": [
1817
"postgres",
1918
"postgreSQL",

0 commit comments

Comments
 (0)