fix

Author: sbdchd

Cargo.toml

@@ -38,6 +38,10 @@ squawk-github = { version = "0.0.0", path = "./crates/github" }
 collapsible_else_if = "allow"
 collapsible_if = "allow"
 needless_return = "allow"
+if_not_else = "allow"
+needless_raw_string_hashes = "allow"
+cast_possible_truncation = "allow"
+semicolon_if_nothing_returned = "allow"
 
 [profile.dev]
 debug = 0

crates/squawk_lexer/src/cursor.rs

@@ -5,8 +5,8 @@ use std::str::Chars;
 /// Next characters can be peeked via `first` method,
 /// and position can be shifted forward via `bump` method.
 /// based on:
-/// - https://github.com/rust-lang/rust/blob/d1b7355d3d7b4ead564dbecb1d240fcc74fff21b/compiler/rustc_lexer/src/cursor.rs
-/// - https://github.com/astral-sh/ruff/blob/d1079680bb29f6b797b5df15327195300f635f3c/crates/ruff_python_parser/src/lexer/cursor.rs
+/// - <https://github.com/rust-lang/rust/blob/d1b7355d3d7b4ead564dbecb1d240fcc74fff21b/compiler/rustc_lexer/src/cursor.rs>
+/// - <https://github.com/astral-sh/ruff/blob/d1079680bb29f6b797b5df15327195300f635f3c/crates/ruff_python_parser/src/lexer/cursor.rs>
 ///
 pub(crate) struct Cursor<'a> {
     /// Iterator over chars. Slightly faster than a &str.

crates/squawk_lexer/src/lib.rs

@@ -32,9 +32,8 @@ const fn is_whitespace(c: char) -> bool {
 impl Cursor<'_> {
     // see: https://github.com/rust-lang/rust/blob/ba1d7f4a083e6402679105115ded645512a7aea8/compiler/rustc_lexer/src/lib.rs#L339
     pub(crate) fn advance_token(&mut self) -> Token {
-        let first_char = match self.bump() {
-            Some(c) => c,
-            None => return Token::new(TokenKind::Eof, 0),
+        let Some(first_char) = self.bump() else {
+            return Token::new(TokenKind::Eof, 0);
         };
         let token_kind = match first_char {
             // Slash, comment or block comment.
@@ -418,7 +417,7 @@ impl Cursor<'_> {
 
                 // might be the start of our start/end sequence
                 let mut match_count = 0;
-                for start_char in start.iter() {
+                for start_char in &start {
                     if self.first() == *start_char {
                         self.bump();
                         match_count += 1;

crates/squawk_lexer/src/token.rs

@@ -79,13 +79,13 @@ pub enum TokenKind {
     UnknownPrefix,
     /// Positional Parameter, e.g., `$1`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-expressions.html#SQL-EXPRESSIONS-PARAMETERS-POSITIONAL
+    /// see: <https://www.postgresql.org/docs/16/sql-expressions.html#SQL-EXPRESSIONS-PARAMETERS-POSITIONAL>
     Param,
     /// Quoted Identifier, e.g., `"update"` in `update "my_table" set "a" = 5;`
     ///
     /// These are case-sensitive, unlike [`TokenKind::Ident`]
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS>
     QuotedIdent { terminated: bool },
 }
 
@@ -122,34 +122,34 @@ pub enum Base {
 pub enum LiteralKind {
     /// Integer Numeric, e.g., `42`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS-NUMERIC
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS-NUMERIC>
     Int { base: Base, empty_int: bool },
     /// Float Numeric, e.g., `1.925e-3`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS-NUMERIC
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS-NUMERIC>
     Float { base: Base, empty_exponent: bool },
     /// String, e.g., `'foo'`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS>
     Str { terminated: bool },
     /// Hexidecimal Bit String, e.g., `X'1FF'`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-BIT-STRINGS
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-BIT-STRINGS>
     ByteStr { terminated: bool },
     /// Bit String, e.g., `B'1001'`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-BIT-STRINGS
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-BIT-STRINGS>
     BitStr { terminated: bool },
     /// Dollar Quoted String, e.g., `$$Dianne's horse$$`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING>
     DollarQuotedString { terminated: bool },
     /// Unicode Escape String, e.g., `U&'d\0061t\+000061'`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-UESCAPE
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-UESCAPE>
     UnicodeEscStr { terminated: bool },
     /// Escape String, e.g, `E'foo'`
     ///
-    /// see: https://www.postgresql.org/docs/16/sql-syntax-lexical.html
+    /// see: <https://www.postgresql.org/docs/16/sql-syntax-lexical.html>
     EscStr { terminated: bool },
 }