parser: fill out create type as enum nodes (#685)

Author: sbdchd

crates/squawk_ide/src/expand_selection.rs

@@ -51,6 +51,7 @@ const ALL_LIST_KINDS: &[SyntaxKind] = &[
     SyntaxKind::TARGET_LIST,
     SyntaxKind::TRANSACTION_MODE_LIST,
     SyntaxKind::VACUUM_OPTION_LIST,
+    SyntaxKind::VARIANT_LIST,
     // only separated by whitespace
     // SyntaxKind::XML_COLUMN_OPTION_LIST,
     SyntaxKind::XML_TABLE_COLUMN_LIST,
@@ -572,6 +573,7 @@ $0
             TARGET_LIST,
             TRANSACTION_MODE_LIST,
             VACUUM_OPTION_LIST,
+            VARIANT_LIST,
             XML_TABLE_COLUMN_LIST,
         ]
         ");

crates/squawk_parser/src/generated/syntax_kind.rs

@@ -12926,15 +12926,7 @@ fn create_type(p: &mut Parser<'_>) -> CompletedMarker {
     if p.eat(AS_KW) {
         // AS ENUM
         if p.eat(ENUM_KW) {
-            delimited(
-                p,
-                L_PAREN,
-                R_PAREN,
-                COMMA,
-                || "unexpected comma".to_string(),
-                STRING_FIRST,
-                |p| opt_string_literal(p).is_some(),
-            );
+            variant_list(p);
             // AS RANGE
         } else if p.eat(RANGE_KW) {
             attribute_list(p);
@@ -12959,6 +12951,30 @@ fn create_type(p: &mut Parser<'_>) -> CompletedMarker {
     m.complete(p, CREATE_TYPE)
 }
 
+fn opt_variant(p: &mut Parser<'_>) -> bool {
+    let m = p.start();
+    if opt_string_literal(p).is_none() {
+        m.abandon(p);
+        return false;
+    }
+    m.complete(p, VARIANT);
+    true
+}
+
+fn variant_list(p: &mut Parser<'_>) {
+    let m = p.start();
+    delimited(
+        p,
+        L_PAREN,
+        R_PAREN,
+        COMMA,
+        || "unexpected comma".to_string(),
+        STRING_FIRST,
+        opt_variant,
+    );
+    m.complete(p, VARIANT_LIST);
+}
+
 // CREATE EXTENSION [ IF NOT EXISTS ] extension_name
 //     [ WITH ] [ SCHEMA schema_name ]
 //              [ VERSION version ]

crates/squawk_parser/src/grammar.rs

@@ -125,8 +125,9 @@ SOURCE_FILE
     WHITESPACE " "
     ENUM_KW "enum"
     WHITESPACE " "
-    L_PAREN "("
-    R_PAREN ")"
+    VARIANT_LIST
+      L_PAREN "("
+      R_PAREN ")"
   SEMICOLON ";"
   WHITESPACE "\n"
   CREATE_TYPE
@@ -143,10 +144,12 @@ SOURCE_FILE
     WHITESPACE " "
     ENUM_KW "enum"
     WHITESPACE " "
-    L_PAREN "("
-    LITERAL
-      STRING "'a'"
-    R_PAREN ")"
+    VARIANT_LIST
+      L_PAREN "("
+      VARIANT
+        LITERAL
+          STRING "'a'"
+      R_PAREN ")"
   SEMICOLON ";"
   WHITESPACE "\n"
   CREATE_TYPE
@@ -163,18 +166,22 @@ SOURCE_FILE
     WHITESPACE " "
     ENUM_KW "enum"
     WHITESPACE " "
-    L_PAREN "("
-    LITERAL
-      STRING "'a'"
-    COMMA ","
-    WHITESPACE " "
-    LITERAL
-      STRING "'b'"
-    COMMA ","
-    WHITESPACE " "
-    LITERAL
-      STRING "'c'"
-    R_PAREN ")"
+    VARIANT_LIST
+      L_PAREN "("
+      VARIANT
+        LITERAL
+          STRING "'a'"
+      COMMA ","
+      WHITESPACE " "
+      VARIANT
+        LITERAL
+          STRING "'b'"
+      COMMA ","
+      WHITESPACE " "
+      VARIANT
+        LITERAL
+          STRING "'c'"
+      R_PAREN ")"
   SEMICOLON ";"
   WHITESPACE "\n\n"
   COMMENT "-- create_type_as_range"

crates/squawk_parser/tests/snapshots/tests__create_type_ok.snap

@@ -1627,6 +1627,19 @@ IndexParams =
 CreateType =
   'create' 'type' Type
 
+  (('as' 'enum' VariantList)
+| ('as' 'range' )
+| ('as' '(' ')')
+| ('(' ')'))
+
+VariantList =
+  '('
+  (Variant (',' Variant)*)
+  ')'
+
+Variant =
+  Literal
+
 CreateExtension =
   'create' 'extension'
 

crates/squawk_syntax/src/ast/generated/nodes.rs

@@ -40,7 +40,7 @@ pub fn dump_tokens(text: String) -> String {
     out
 }
 
-#[allow(dead_code)]
+#[expect(unused)]
 #[derive(Serialize)]
 enum Severity {
     Hint,