Skip to content

Commit abca93b

Browse files
authored
parser: fix reindex parsing (#726)
we were using a name instead of a name_ref for the table name
1 parent 81de967 commit abca93b

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

crates/squawk_parser/src/grammar.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11301,7 +11301,7 @@ fn reindex(p: &mut Parser<'_>) -> CompletedMarker {
1130111301
}
1130211302
};
1130311303
p.eat(CONCURRENTLY_KW);
11304-
if opt_path_name(p).is_none() && name_required {
11304+
if opt_path_name_ref(p).is_none() && name_required {
1130511305
p.error("expected name");
1130611306
}
1130711307
m.complete(p, REINDEX)

crates/squawk_parser/tests/snapshots/tests__reindex_err.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ SOURCE_FILE
2323
WHITESPACE " "
2424
PATH
2525
PATH_SEGMENT
26-
NAME
26+
NAME_REF
2727
IDENT "i"
2828
SEMICOLON ";"
2929
WHITESPACE "\n"

crates/squawk_parser/tests/snapshots/tests__reindex_ok.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ SOURCE_FILE
1212
WHITESPACE " "
1313
PATH
1414
PATH_SEGMENT
15-
NAME
15+
NAME_REF
1616
IDENT "my_index"
1717
SEMICOLON ";"
1818
WHITESPACE "\n\n"
@@ -23,7 +23,7 @@ SOURCE_FILE
2323
WHITESPACE " "
2424
PATH
2525
PATH_SEGMENT
26-
NAME
26+
NAME_REF
2727
IDENT "my_table"
2828
SEMICOLON ";"
2929
WHITESPACE "\n\n"
@@ -36,7 +36,7 @@ SOURCE_FILE
3636
WHITESPACE " "
3737
PATH
3838
PATH_SEGMENT
39-
NAME
39+
NAME_REF
4040
IDENT "my_broken_table"
4141
SEMICOLON ";"
4242
WHITESPACE "\n\n"
@@ -70,7 +70,7 @@ SOURCE_FILE
7070
WHITESPACE " "
7171
PATH
7272
PATH_SEGMENT
73-
NAME
73+
NAME_REF
7474
IDENT "foo"
7575
SEMICOLON ";"
7676
WHITESPACE "\n\n"
@@ -81,7 +81,7 @@ SOURCE_FILE
8181
WHITESPACE " "
8282
PATH
8383
PATH_SEGMENT
84-
NAME
84+
NAME_REF
8585
IDENT "foo"
8686
SEMICOLON ";"
8787
WHITESPACE "\n\n"
@@ -92,7 +92,7 @@ SOURCE_FILE
9292
WHITESPACE " "
9393
PATH
9494
PATH_SEGMENT
95-
NAME
95+
NAME_REF
9696
IDENT "foo"
9797
SEMICOLON ";"
9898
WHITESPACE "\n"
@@ -103,7 +103,7 @@ SOURCE_FILE
103103
WHITESPACE " "
104104
PATH
105105
PATH_SEGMENT
106-
NAME
106+
NAME_REF
107107
IDENT "foo"
108108
SEMICOLON ";"
109109
WHITESPACE "\n"
@@ -114,7 +114,7 @@ SOURCE_FILE
114114
WHITESPACE " "
115115
PATH
116116
PATH_SEGMENT
117-
NAME
117+
NAME_REF
118118
IDENT "foo"
119119
SEMICOLON ";"
120120
WHITESPACE "\n\n"

0 commit comments

Comments
 (0)