Skip to content

VSCode Extension shows errors ignored by the config file. #679

@dreid

Description

@dreid

squawk-vscode version: 2.28.1
I have a .squawk.toml at the top level of our repository:

assume_in_transaction = true
pg_version = "15"

excluded_paths = [
    "migrations/0000_00_00_initial.sql"
]

excluded_rules = [
    "require-timeout-settings",
    "prefer-timestamptz",
    "prefer-robust-stmts",
    "require-concurrent-index-creation",
    "require-concurrent-index-deletion",
]

The Squawk language server output starts with:

21:31:05 �[0m�[34m[INFO] �[0musing config file path: /Users/dreid/src/repo/.squawk.toml
21:31:05 �[0m�[34m[INFO] �[0mpg version: Some(Version { major: 15, minor: None, patch: None })
21:31:05 �[0m�[34m[INFO] �[0mexcluded rules: [RequireTimeoutSettings, PreferTimestampTz, PreferRobustStmts, RequireConcurrentIndexCreation, RequireConcurrentIndexDeletion]
21:31:05 �[0m�[34m[INFO] �[0mexcluded paths: ["migrations/0000_00_00_initial.sql"]
21:31:05 �[0m�[34m[INFO] �[0massume in a transaction: true
21:31:05 �[0m�[34m[INFO] �[0mno error on unmatched pattern: false
21:31:05 �[0m�[34m[INFO] �[0mStarting Squawk LSP server

Meanwhile a new migration displays:

Image

I would expect to only see the ban-drop-column issue and not the require-timeout-settings issue that is part of the excluded_rules in the config file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions