Don't even try to infer the title when publishing HTML - close #1

sblakey · sblakey · commit 04dd6e36c8eb · 2022-12-28T15:31:03.000-08:00
diff --git a/README.md b/README.md
@@ -14,7 +14,7 @@ Currently, this plugin exposes two Commands:
 ## Installing this plugin as a Beta Tester
 
 1. Install [BRAT](https://github.com/TfTHacker/obsidian42-brat) from the Community Plugins in Obsidian
-2. Copy the link https://github.com/sblakey/obsidian-quip.git
+2. Copy the link https://github.com/sblakey/obsidian-quip
 3. Open the command palette and run the command **BRAT: Add a beta plugin for testing**
 4. Using the link from step 2, copy that into the modal that opens up
 5. Click on Add Plugin -- wait a few seconds and BRAT will tell you what is going on
diff --git a/main.ts b/main.ts
@@ -52,14 +52,13 @@ export default class QuipPlugin extends Plugin {
 					// If checking is false, then we want to actually perform the operation.
 					if (!checking) {
 						let client = new QuipAPIClient(this.settings.hostname, this.settings.token);
-						let title = markdownView.file.basename;
 						// Quip import likes to replace the first heading with the document title
 						const htmlPromise = render(this, markdownView, markdownView.file.path);
 						htmlPromise.then((html: string) => {
 							console.log(html);
 							let options: NewDocumentOptions = {
 								content: html,
-								title: title,
+								title: undefined,
 								format: DocumentFormat.HTML,
 								memberIds: undefined
 							};
@@ -253,6 +252,16 @@ class QuipSettingTab extends PluginSettingTab {
 					this.plugin.settings.addLink = value;
 					await this.plugin.saveSettings();
 				}));
+		new Setting(containerEl)
+			.setName('Inline embedded notes')
+			.setDesc('Replace embed-links with the content of those notes')
+			.addToggle(toggle => toggle
+				.setValue(this.plugin.settings.inlineEmbeds)
+				.onChange(async (value) => {
+					console.log(`Add Link: ${value}`);
+					this.plugin.settings.inlineEmbeds = value;
+					await this.plugin.saveSettings();
+				}));
 	}
 }
 
diff --git a/renderer.ts b/renderer.ts
@@ -77,22 +77,20 @@ export default async function render (plugin: QuipPlugin, view: MarkdownView,
     document.body.removeChild(wrapper);
 
     // If it's a top level note, make the HTML a standalone document - inject CSS, a <title>, etc.
-    const title = fileBaseName(inputFile);
     if (parentFiles.length === 0) {
-        html = await standaloneHTML(html, title);
+        html = await standaloneHTML(html);
     }
 
     return html;
 }
 
-async function standaloneHTML(html: string, title: string): Promise<string> {
+async function standaloneHTML(html: string): Promise<string> {
     // Wraps an HTML fragment in a proper document structure
     // Don't bother with CSS Quip will ignore
 
     return `<!doctype html>\n` +
         `<html>\n` +
         `    <head>\n` +
-        `        <title>${title}</title>\n` +
         `        <meta charset='utf-8'/>\n` +
         `    </head>\n` +
         `    <body>\n` +
