user warn usb

Author: sblantipodi

src/main/java/org/dpsoftware/NativeExecutor.java

@@ -23,7 +23,6 @@
 
 import com.sun.jna.platform.win32.Advapi32Util;
 import com.sun.jna.platform.win32.WinReg;
-import javafx.scene.control.Alert;
 import jdk.incubator.vector.IntVector;
 import lombok.NoArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
@@ -539,22 +538,6 @@ public static boolean isNightLight() {
         return nightLightEnabled;
     }
 
-    /**
-     * Check if user is dialout or uucp to use USB
-     */
-    public static void checkUsbGroup() {
-        try {
-            List<String> scrProcess = runNative(Constants.USB_GRP, Constants.CMD_WAIT_DELAY);
-            boolean isUserAbleToUseUsb = scrProcess.stream().anyMatch(s -> s.contains(Constants.USB_DIALOUT) || s.contains(Constants.USB_UUCP));
-            if (!isUserAbleToUseUsb) {
-                MainSingleton.getInstance().guiManager.showLocalizedAlert(Constants.USB_NOT_AVAILABLE_TITLE, Constants.USB_NOT_AVAILABLE_HEADER,
-                        Constants.USB_NOT_AVAILABLE_CONTENT, Alert.AlertType.WARNING);
-            }
-        } catch (Exception e) {
-            log.warn(e.getMessage());
-        }
-    }
-
     /**
      * Remove Windows registry key used to Launch Firefly Luciferin when system starts
      */

src/main/java/org/dpsoftware/config/Constants.java

@@ -778,9 +778,6 @@ public class Constants {
     public static final String[] CMD_CUDA_CHECK = {"/bin/sh", "-c", "gst-inspect-1.0 nvcodec | grep cuda"};
     public static final String[] PING_WINDOWS = {"ping", "-n", "1"};
     public static final String[] PING_LINUX = {"ping", "-c", "1"};
-    public static final String[] USB_GRP = {"id", "-Gn"};
-    public static final String USB_DIALOUT = "dialout";
-    public static final String USB_UUCP = "uucp";
     public static final String[] CUDA_REQUIRED_PLUGINS = {"cudaupload", "cudascale", "cudaconvert", "cudadownload"};
     public static final String OBJPATH_KDE_NIGHTLIGHT = "/org/kde/KWin/NightLight";
     public static final String PROP_KDE_NIGHTLIGHT = "enabled";

src/main/java/org/dpsoftware/managers/SerialManager.java

@@ -24,6 +24,8 @@
 import com.fazecast.jSerialComm.SerialPort;
 import com.fazecast.jSerialComm.SerialPortDataListener;
 import com.fazecast.jSerialComm.SerialPortEvent;
+import javafx.application.Platform;
+import javafx.scene.control.Alert;
 import lombok.extern.slf4j.Slf4j;
 import org.dpsoftware.MainSingleton;
 import org.dpsoftware.NativeExecutor;
@@ -58,6 +60,7 @@ public class SerialManager {
 
     ScheduledExecutorService serialAttachScheduler = Executors.newScheduledThreadPool(1);
     private ScheduledFuture<?> scheduledFuture;
+    boolean alertSent = false;
 
     /**
      * Initialize Serial communication
@@ -70,9 +73,6 @@ public void initSerial() {
      * Initialize Serial communication
      */
     public void initSerial(String portName, String baudrate) {
-        if (NativeExecutor.isLinux()) {
-            NativeExecutor.checkUsbGroup();
-        }
         if (!MainSingleton.getInstance().config.isWirelessStream() || !portName.isEmpty()) {
             CommonUtility.delayMilliseconds(() -> {
                 try {
@@ -140,6 +140,11 @@ private void openSerial(String portName, String baudrate, int readTimeout, int w
             MainSingleton.getInstance().output = MainSingleton.getInstance().serial.getOutputStream();
             listenSerialEvents();
         } else {
+            if (NativeExecutor.isLinux() && !alertSent) {
+                alertSent = true;
+                Platform.runLater(() -> MainSingleton.getInstance().guiManager.showLocalizedAlert(Constants.USB_NOT_AVAILABLE_TITLE, Constants.USB_NOT_AVAILABLE_HEADER,
+                        Constants.USB_NOT_AVAILABLE_CONTENT, Alert.AlertType.WARNING));
+            }
             MainSingleton.getInstance().communicationError = true;
         }
     }