Changes rate rule converter error to warning

The rate rule converter previously treated the absence of rate
rules as an error, causing conversion to fail. This change
corrects this behavior by downgrading the error to a warning and
allowing the conversion to proceed successfully. This ensures
that models without rate rules are handled gracefully.

Author: skeating

src/sbml/SBMLErrorTable.h

@@ -8095,15 +8095,15 @@ static const sbmlErrorTableEntry errorTable[] =
     ModelContainsNoRateRules,
     "Model contains no rate rules",
     LIBSBML_CAT_RATE_RULE_CONVERSION,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
-    LIBSBML_SEV_ERROR,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
+    LIBSBML_SEV_WARNING,
     "The model contains no rate rules and so cannot be converted to reactions.",
     {"",
      "",
@@ -8115,7 +8115,7 @@ static const sbmlErrorTableEntry errorTable[] =
      ""}
    },
 
-   //90103
+   //90103S.NESSTALENT SLEEP
   {
     ModelAlreadyContainsReactions,
     "Model already contains reactions",

src/sbml/conversion/SBMLRateRuleConverter.cpp

@@ -380,8 +380,8 @@ SBMLRateRuleConverter::isDocumentAppropriate(OperationReturnValues_t& returnValu
   {
       mDocument->getErrorLog()->logError(ModelContainsNoRateRules, mDocument->getLevel(),
           mDocument->getVersion(), "There are no rate rules present.");
-      returnValue = LIBSBML_OPERATION_FAILED;
-      return false;
+      returnValue = LIBSBML_OPERATION_SUCCESS;
+      return true;
   }
   else
   {
@@ -399,7 +399,7 @@ SBMLRateRuleConverter::isDocumentAppropriate(OperationReturnValues_t& returnValu
     {
         mDocument->getErrorLog()->logError(ModelContainsNoRateRules, mDocument->getLevel(),
             mDocument->getVersion(), "There are no rate rules present.");
-        returnValue = LIBSBML_OPERATION_FAILED;
+        returnValue = LIBSBML_OPERATION_SUCCESS;
         return false;
     }
   }

src/sbml/conversion/test/TestRoundtripConverter.cpp

@@ -6,8 +6,7 @@
  * <!--------------------------------------------------------------------------
  * This file is part of libSBML.  Please visit http://sbml.org for more
  * information about SBML, and the latest version of libSBML.
- *
- * Copyright (C) 2013-2018 jointly by the following organizations:
+ * 
  *     1. California Institute of Technology, Pasadena, CA, USA
  *     2. EMBL European Bioinformatics Institute (EMBL-EBI), Hinxton, UK
  *     3. University of Heidelberg, Heidelberg, Germany

src/sbml/conversion/test/TestSBMLRateRuleConverter.cpp

@@ -231,7 +231,7 @@ START_TEST(test_conversion_raterule_converter_invalid)
 
   rule_rn_converter->setDocument(doc);
 
-  fail_unless(rule_rn_converter->convert() == LIBSBML_OPERATION_FAILED);
+  fail_unless(rule_rn_converter->convert() == LIBSBML_OPERATION_SUCCESS);
 
   Parameter* parameter1 = model->createParameter();
   parameter1->setId("s");
@@ -1062,7 +1062,7 @@ START_TEST(test_converter_errors_1)
 
 	rule_rn_converter->setDocument(d);
 	int ret = rule_rn_converter->convert();
-	fail_unless(ret == LIBSBML_OPERATION_FAILED);
+	fail_unless(ret == LIBSBML_OPERATION_SUCCESS);
 	fail_unless(d->getNumErrors() == 1);
 	fail_unless(d->getError(0)->getErrorId() == 90102);
 	fail_unless(d->getError(0)->getCategory() == LIBSBML_CAT_RATE_RULE_CONVERSION);
@@ -1084,7 +1084,7 @@ START_TEST(test_converter_errors_2)
 
 	rule_rn_converter->setDocument(d);
 	int ret = rule_rn_converter->convert();
-	fail_unless(ret == LIBSBML_OPERATION_FAILED);
+    fail_unless(ret == LIBSBML_OPERATION_SUCCESS);
 	fail_unless(d->getNumErrors() == 1);
 	fail_unless(d->getError(0)->getErrorId() == 90102);
 	fail_unless(d->getError(0)->getCategory() == LIBSBML_CAT_RATE_RULE_CONVERSION);