Use auto * where appropriate (#719)

Author: sbooth

Sources/CSFBAudioEngine/Player/AudioPlayer.mm

@@ -605,7 +605,7 @@ bool PerformSeek() noexcept
 SFB::AudioPlayer::Decoder SFB::AudioPlayer::CurrentDecoder() const noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
-	const auto decoderState = FirstActiveDecoderState();
+	const auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState)
 		return nil;
 	return decoderState->decoder_;
@@ -633,7 +633,7 @@ bool PerformSeek() noexcept
 SFBPlaybackPosition SFB::AudioPlayer::PlaybackPosition() const noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
-	const auto decoderState = FirstActiveDecoderState();
+	const auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState)
 		return SFBInvalidPlaybackPosition;
 	return { .framePosition = decoderState->FramePosition(), .frameLength = decoderState->FrameLength() };
@@ -643,7 +643,7 @@ bool PerformSeek() noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	const auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState)
 		return SFBInvalidPlaybackTime;
 
@@ -666,7 +666,7 @@ bool PerformSeek() noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	const auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState) {
 		if(playbackPosition)
 			*playbackPosition = SFBInvalidPlaybackPosition;
@@ -699,7 +699,7 @@ bool PerformSeek() noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState || !decoderState->decoder_.supportsSeeking)
 		return false;
 
@@ -723,7 +723,7 @@ bool PerformSeek() noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState || !decoderState->decoder_.supportsSeeking)
 		return false;
 
@@ -745,7 +745,7 @@ bool PerformSeek() noexcept
 
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState || !decoderState->decoder_.supportsSeeking)
 		return false;
 
@@ -762,7 +762,7 @@ bool PerformSeek() noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
 
-	const auto decoderState = FirstActiveDecoderState();
+	auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState || !decoderState->decoder_.supportsSeeking)
 		return false;
 
@@ -778,7 +778,7 @@ bool PerformSeek() noexcept
 bool SFB::AudioPlayer::SupportsSeeking() const noexcept
 {
 	std::lock_guard lock{activeDecodersLock_};
-	const auto decoderState = FirstActiveDecoderState();
+	const auto *decoderState = FirstActiveDecoderState();
 	if(!decoderState)
 		return false;
 	return decoderState->decoder_.supportsSeeking;
@@ -1394,7 +1394,7 @@ bool PerformSeek() noexcept
 			return;
 		}
 
-		if(const auto decoderState = FirstActiveDecoderState(); decoderState)
+		if(const auto *decoderState = FirstActiveDecoderState(); decoderState)
 			currentDecoder = decoderState->decoder_;
 	}