Skip to content

Commit 9c4c02e

Browse files
authored
Merge pull request kubernetes-sigs#7965 from ykakarap/add-disablenodelabelsync-comment
🌱 add comment to disableNodeLabelSync
2 parents 3aca5b3 + d08f6a8 commit 9c4c02e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

internal/controllers/machine/machine_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,11 @@ type Reconciler struct {
9191
// nodeDeletionRetryTimeout determines how long the controller will retry deleting a node
9292
// during a single reconciliation.
9393
nodeDeletionRetryTimeout time.Duration
94-
disableNodeLabelSync bool
94+
95+
// disableNodeLabelSync should only be used for tests. This is used to skip the parts of
96+
// the controller that need SSA as the current test setup does not support SSA.
97+
// This flag should be dropped after the tests are migrated to envtest.
98+
disableNodeLabelSync bool
9599
}
96100

97101
func (r *Reconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager, options controller.Options) error {

0 commit comments

Comments
 (0)