Skip to content

Commit e399485

Browse files
authored
Fix: name as path when initializing (#208)
1 parent 22face1 commit e399485

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.changeset/chatty-mugs-allow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"create-eth": patch
3+
---
4+
5+
cli: allow projectName as path while initlializing the cli

src/utils/prompt-for-missing-options.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { Options, RawOptions, SolidityFrameworkChoices } from "../types";
22
import inquirer from "inquirer";
33
import { SOLIDITY_FRAMEWORKS } from "./consts";
44
import { validateNpmName } from "./validate-name";
5-
import { basename, resolve } from "path";
65

76
// default values for unspecified args
87
const defaultOptions: RawOptions = {
@@ -26,7 +25,7 @@ export async function promptForMissingOptions(
2625
message: "Your project name:",
2726
default: defaultOptions.project,
2827
validate: (name: string) => {
29-
const validation = validateNpmName(basename(resolve(name)));
28+
const validation = validateNpmName(name);
3029
if (validation.valid) {
3130
return true;
3231
}

src/utils/validate-name.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { basename, resolve } from "path";
12
import validateProjectName from "validate-npm-package-name";
23

34
type ValidateNpmNameResult =
@@ -10,7 +11,7 @@ type ValidateNpmNameResult =
1011
};
1112

1213
export function validateNpmName(name: string): ValidateNpmNameResult {
13-
const nameValidation = validateProjectName(name);
14+
const nameValidation = validateProjectName(basename(resolve(name)));
1415
if (nameValidation.validForNewPackages) {
1516
return { valid: true };
1617
}

0 commit comments

Comments
 (0)