-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
This issue is being used to capture further improvements to the ROI and scholia functionality.
We hope to revisit this in the future, but it is not currently in scope.
Developer Notes
- We had explored some connectivity between the sidebar widget and main reader pane with a "scroll into view" affordance; worth a second look
- We may wish to support filtering the sidebar scholia by a particular "kind"
- We also may wish to decouple styles of each "scholia kind" from HMT (providing a text annotation collection manifest)
- We should improve the integration of click handlers
- Make "highlights" mode persist on click (scaife-viewer/frontend@325b1de)
- Emit both "passage" level and "text annotation" level handlers (e.g., clicking a scholia entry should in "highlight" mode should retain the ROI bounding box; it is currently cleared because the handler assumes a "line-level" handler (passing the
userDataobject to our click handlers could help, e.g. scaife-viewer/frontend@57f49f8)
- Optimize queries so we don't have to deal with the "stuffing" of
textAnnotation.edgesinto our queries (https://github.com/scaife-viewer/frontend/blob/325b1de5933e6f0a82f3bfbc60ddbdca1026af2c/packages/widget-scholia/src/ScholiaWidget.vue#L65, https://github.com/scaife-viewer/frontend/blob/325b1de5933e6f0a82f3bfbc60ddbdca1026af2c/packages/reader-image-mode/src/ImageModeReader.vue#L108)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels