Add test for boolean options and imrove formatting

Author: jchyb

README.md

@@ -14,5 +14,3 @@ Since options are dependent on the used version of scala-native-cli, please use
 ## Logging 
 
 For logging purposes, a default Scala Native logger is used. By default it will only show `Error` messages, but its verbosity can be increased with a -v flag.
-
-

cli/src/test/scala/scala/scalanative/cli/ConfigConverterTest.scala

@@ -20,7 +20,7 @@ class ConfigConverterTest extends AnyFlatSpec {
   val dummyMiscOptions = MiscOptions()
 
   val dummyArguments =
-    Seq("$Main", "A.nir", "B.nir")
+    Seq("Main$", "A.nir", "B.nir")
 
   val dummyCliOptions = CliOptions(
     config = dummyConfigOptions,
@@ -34,7 +34,6 @@ class ConfigConverterTest extends AnyFlatSpec {
     assert(config.isRight)
   }
 
-  // TODO incomplete arguments check reporting
   it should "report incomplete arguments" in {
     val noArgs = Seq()
     val noArgsResult = ConfigConverter.convert(dummyCliOptions, noArgs)
@@ -52,7 +51,7 @@ class ConfigConverterTest extends AnyFlatSpec {
       "/home/dir/file",
       "/home/dirfile2",
       "/home/dir/with spaces/"
-    ) // check case app passing with spaces
+    )
     val expected = Seq(
       Paths.get("/home/dir/file"),
       Paths.get("/home/dirfile2"),
@@ -147,4 +146,35 @@ class ConfigConverterTest extends AnyFlatSpec {
     assert(nativeConfig.config.compilerConfig.clang == expectedClangPath)
     assert(nativeConfig.config.compilerConfig.clangPP == expectedClangPPPath)
   }
+
+  it should "parse boolean options as opposite of default" in {
+    val options = CliOptions(
+      dummyConfigOptions,
+      NativeConfigOptions(
+        check = true,
+        dump = true,
+        noOptimize = true,
+        linkStubs = true
+      ),
+      dummyLoggerOptions,
+      dummyMiscOptions
+    )
+    val default = ConfigConverter
+      .convert(dummyCliOptions, dummyArguments)
+      .right
+      .get
+      .config
+      .compilerConfig
+    val nonDefault = ConfigConverter
+      .convert(options, dummyArguments)
+      .right
+      .get
+      .config
+      .compilerConfig
+
+    assert(nonDefault.check != default.check)
+    assert(nonDefault.dump != default.dump)
+    assert(nonDefault.optimize != default.optimize)
+    assert(nonDefault.linkStubs != default.linkStubs)
+  }
 }

cli/version_newer/src/main/scala/scala/scalanative/cli/utils/LinktimePropertyParser.scala

@@ -19,7 +19,10 @@ object LinktimePropertyParser {
       ltpStrings
         .map { inputPattern =>
           val matcher = ltpPattern.matcher(inputPattern)
-          if (!matcher.find() || matcher.groupCount() != 2 || matcher.group(1).isEmpty()) {
+          if (
+            !matcher
+              .find() || matcher.groupCount() != 2 || matcher.group(1).isEmpty()
+          ) {
             Left(getLtpPatternException(inputPattern))
           } else {
             val (key, booleanString) = (matcher.group(1), matcher.group(2))

cli/version_newer/src/test/scala/scala/scalanative/cli/LinktimePropertyParserTest.scala

@@ -7,7 +7,8 @@ class LinktimePropertyParserTest extends AnyFlatSpec {
 
   "LinktimePropertyParser" should "handle boolean value types correctly" in {
     val input = List("isTesting=true", "isNotTesting=False")
-    val expected = Map[String, Any]("isTesting" -> true, "isNotTesting" -> false)
+    val expected =
+      Map[String, Any]("isTesting" -> true, "isNotTesting" -> false)
     val obtained = LinktimePropertyParser.toMap(input)
     assert(obtained.right.get == expected)
   }

scala-native-cli-integration-test-runner/src/test/run/integration-test/test

@@ -29,7 +29,3 @@ $ mkdir native-dir
 > runCli --outpath target/out6 -v -v --workdir native-dir --dump Main$
 $ exists native-dir/optimized.hnir
 $ exists target/out6
-
-# -- Fail on an incorrect link-time property
-> runCli --outpath target/out7 -v -v --ltp key=ok Main$
--$ exists target/out7