Skip to content

Commit 1a089c0

Browse files
Change updatePullRequest to return Unit
1 parent 2609bc6 commit 1a089c0

File tree

8 files changed

+13
-45
lines changed

8 files changed

+13
-45
lines changed

modules/core/src/main/scala/org/scalasteward/core/forge/ForgeApiAlg.scala

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@ trait ForgeApiAlg[F[_]] {
2727

2828
def createPullRequest(repo: Repo, data: NewPullRequestData): F[PullRequestOut]
2929

30-
def updatePullRequest(
31-
number: PullRequestNumber,
32-
repo: Repo,
33-
data: NewPullRequestData
34-
): F[PullRequestOut]
30+
def updatePullRequest(number: PullRequestNumber, repo: Repo, data: NewPullRequestData): F[Unit]
3531

3632
def closePullRequest(repo: Repo, number: PullRequestNumber): F[PullRequestOut]
3733

modules/core/src/main/scala/org/scalasteward/core/forge/azurerepos/AzureReposApiAlg.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ final class AzureReposApiAlg[F[_]](
5858
number: PullRequestNumber,
5959
repo: Repo,
6060
data: NewPullRequestData
61-
): F[PullRequestOut] =
61+
): F[Unit] =
6262
F.raiseError(new NotImplementedError(s"updatePullRequest($number, $repo, $data)"))
6363

6464
// https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull-requests/update?view=azure-devops-rest-7.1

modules/core/src/main/scala/org/scalasteward/core/forge/bitbucket/BitbucketApiAlg.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ class BitbucketApiAlg[F[_]](
101101
number: PullRequestNumber,
102102
repo: Repo,
103103
data: NewPullRequestData
104-
): F[PullRequestOut] =
104+
): F[Unit] =
105105
F.raiseError(new NotImplementedError(s"updatePullRequest($number, $repo, $data)"))
106106

107107
override def getBranch(repo: Repo, branch: Branch): F[BranchOut] =

modules/core/src/main/scala/org/scalasteward/core/forge/bitbucketserver/BitbucketServerApiAlg.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ final class BitbucketServerApiAlg[F[_]](
9090
number: PullRequestNumber,
9191
repo: Repo,
9292
data: NewPullRequestData
93-
): F[PullRequestOut] =
93+
): F[Unit] =
9494
F.raiseError(new NotImplementedError(s"updatePullRequest($number, $repo, $data)"))
9595

9696
private def useDefaultReviewers(repo: Repo): F[List[Reviewer]] =

modules/core/src/main/scala/org/scalasteward/core/forge/gitea/GiteaApiAlg.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ final class GiteaApiAlg[F[_]: HttpJsonClient](
190190
number: PullRequestNumber,
191191
repo: Repo,
192192
data: NewPullRequestData
193-
): F[PullRequestOut] =
193+
): F[Unit] =
194194
F.raiseError(new NotImplementedError(s"updatePullRequest($number, $repo, $data)"))
195195

196196
override def closePullRequest(repo: Repo, number: PullRequestNumber): F[PullRequestOut] = {

modules/core/src/main/scala/org/scalasteward/core/forge/github/GitHubApiAlg.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ final class GitHubApiAlg[F[_]](
7070
number: PullRequestNumber,
7171
repo: Repo,
7272
data: NewPullRequestData
73-
): F[PullRequestOut] = {
73+
): F[Unit] = {
7474
val payload = UpdatePullRequestPayload.from(data)
7575

7676
val update = client
@@ -82,11 +82,11 @@ final class GitHubApiAlg[F[_]](
8282
.adaptErr(SecondaryRateLimitExceeded.fromThrowable)
8383

8484
for {
85-
pullRequestOut <- update
85+
_ <- update
8686
_ <- F.whenA(data.labels.nonEmpty)(labelPullRequest(repo, number, data.labels))
8787
_ <- F.whenA(data.assignees.nonEmpty)(addAssignees(repo, number, data.assignees))
8888
_ <- F.whenA(data.reviewers.nonEmpty)(addReviewers(repo, number, data.reviewers))
89-
} yield pullRequestOut
89+
} yield ()
9090
}
9191

9292
/** https://docs.github.com/en/rest/repos/branches?apiVersion=2022-11-28#get-branch */

modules/core/src/main/scala/org/scalasteward/core/forge/gitlab/GitLabApiAlg.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ final class GitLabApiAlg[F[_]: Parallel](
252252
number: PullRequestNumber,
253253
repo: Repo,
254254
data: NewPullRequestData
255-
): F[PullRequestOut] =
255+
): F[Unit] =
256256
F.raiseError(new NotImplementedError(s"updatePullRequest($number, $repo, $data)"))
257257

258258
private def mergePipelineUponSuccess(repo: Repo, mr: MergeRequestOut): F[MergeRequestOut] =

modules/core/src/test/scala/org/scalasteward/core/forge/github/GitHubApiAlgTest.scala

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -337,14 +337,7 @@ class GitHubApiAlgTest extends CatsEffectSuite with Http4sDsl[MockEff] {
337337

338338
val pr = gitHubApiAlg.updatePullRequest(number, repo, data).runA(state)
339339

340-
val expected = PullRequestOut(
341-
uri"https://github.com/octocat/Hello-World/pull/42",
342-
PullRequestState.Open,
343-
number,
344-
"updated-title"
345-
)
346-
347-
assertIO(pr, expected)
340+
assertIO(pr, ())
348341
}
349342

350343
test("createPullRequest with assignees and reviewers") {
@@ -376,14 +369,7 @@ class GitHubApiAlgTest extends CatsEffectSuite with Http4sDsl[MockEff] {
376369

377370
val pr = gitHubApiAlg.updatePullRequest(number, repo, data).runA(state)
378371

379-
val expected = PullRequestOut(
380-
uri"https://github.com/octocat/Hello-World/pull/42",
381-
PullRequestState.Open,
382-
number,
383-
"updated-title"
384-
)
385-
386-
assertIO(pr, expected)
372+
assertIO(pr, ())
387373
}
388374

389375
test("createPullRequest with assignees and reviewers should not fail if can't assign") {
@@ -427,14 +413,7 @@ class GitHubApiAlgTest extends CatsEffectSuite with Http4sDsl[MockEff] {
427413
.updatePullRequest(number, repo.copy(repo = "cant-assign-reviewers"), data)
428414
.runA(state)
429415

430-
val expected = PullRequestOut(
431-
uri"https://github.com/fthomas/cant-assign-reviewers/pull/42",
432-
PullRequestState.Open,
433-
number,
434-
"updated-title"
435-
)
436-
437-
assertIO(pr, expected)
416+
assertIO(pr, ())
438417
}
439418

440419
test("createPullRequest with labels") {
@@ -466,14 +445,7 @@ class GitHubApiAlgTest extends CatsEffectSuite with Http4sDsl[MockEff] {
466445

467446
val pr = gitHubApiAlg.updatePullRequest(number, repo, data).runA(state)
468447

469-
val expected = PullRequestOut(
470-
uri"https://github.com/octocat/Hello-World/pull/42",
471-
PullRequestState.Open,
472-
number,
473-
"updated-title"
474-
)
475-
476-
assertIO(pr, expected)
448+
assertIO(pr, ())
477449
}
478450

479451
test("createPullRequest should fail when can't add labels") {

0 commit comments

Comments
 (0)