Set http.agent Java property (#2331)

* Set `http.agent` Java property

Follow-up to #2330. This also sets the `http.agent` Java property which
is used for `java.net.HttpURLConnection`'s `User-Agent`. `HttpURLConnection`
is used in this code base by Coursier and the default `FileAlg#readUri`
implementation.

* Do not add login to User-Agent

Author: fthomas

modules/core/src/main/scala/org/scalasteward/core/application/Context.scala

@@ -16,7 +16,6 @@
 
 package org.scalasteward.core.application
 
-import cats.ApplicativeThrow
 import cats.effect._
 import cats.effect.implicits._
 import cats.syntax.all._
@@ -82,7 +81,8 @@ object Context {
       logger <- Resource.eval(Slf4jLogger.fromName[F]("org.scalasteward.core"))
       _ <- Resource.eval(printBanner(logger))
       config = Config.from(args)
-      userAgent <- Resource.eval(mkUserAgent[F](config.vcsCfg.login))
+      _ <- Resource.eval(F.delay(System.setProperty("http.agent", userAgentString)))
+      userAgent <- Resource.eval(F.fromEither(`User-Agent`.parse(userAgentString)))
       client <- OkHttpBuilder
         .withDefaultClient[F]
         .flatMap(_.resource)
@@ -173,9 +173,6 @@ object Context {
     logger.info(msg)
   }
 
-  private def mkUserAgent[F[_]](login: String)(implicit F: ApplicativeThrow[F]): F[`User-Agent`] = {
-    val s = s"Scala-Steward/${org.scalasteward.core.BuildInfo.version}" +
-      s" (operated by $login; ${org.scalasteward.core.BuildInfo.gitHubUrl})"
-    F.fromEither(`User-Agent`.parse(s))
-  }
+  private val userAgentString: String =
+    s"Scala-Steward/${org.scalasteward.core.BuildInfo.version} (${org.scalasteward.core.BuildInfo.gitHubUrl})"
 }