Test FileAlg.isRegularFile (#1896)

Author: fthomas

modules/core/src/main/scala/org/scalasteward/core/application/SelfCheckAlg.scala

@@ -21,8 +21,9 @@ import cats.syntax.all._
 import io.chrisdavenport.log4cats.Logger
 import org.http4s.Uri
 import org.scalasteward.core.git.GitAlg
-import org.scalasteward.core.scalafmt.ScalafmtAlg
+import org.scalasteward.core.scalafmt.{scalafmtBinary, ScalafmtAlg}
 import org.scalasteward.core.util.UrlChecker
+import org.scalasteward.core.util.logger.LoggerOps
 
 final class SelfCheckAlg[F[_]](implicit
     gitAlg: GitAlg[F],
@@ -40,23 +41,18 @@ final class SelfCheckAlg[F[_]](implicit
     } yield ()
 
   private def checkGitBinary: F[Unit] =
-    gitAlg.version.attempt.flatMap {
-      case Right(output) => logger.info(s"Using $output")
-      case Left(throwable) =>
-        logger.warn(throwable)(
-          "Failed to execute git -- make sure it is on the PATH; following the detailed exception:"
-        )
+    logger.attemptLogWarn_(execFailedMessage("git")) {
+      gitAlg.version.flatMap(output => logger.info(s"Using $output"))
     }
 
   private def checkScalafmtBinary: F[Unit] =
-    scalafmtAlg.version.attempt.flatMap {
-      case Right(output) => logger.info(s"Using $output")
-      case Left(throwable) =>
-        logger.warn(throwable)(
-          "Failed to execute scalafmt  -- make sure it is on the PATH; following the detailed exception:"
-        )
+    logger.attemptLogWarn_(execFailedMessage(scalafmtBinary)) {
+      scalafmtAlg.version.flatMap(output => logger.info(s"Using $output"))
     }
 
+  private def execFailedMessage(binary: String): String =
+    s"Failed to execute $binary  -- make sure it is on the PATH; following the detailed exception:"
+
   private def checkUrlChecker: F[Unit] =
     for {
       url <- F.fromEither(Uri.fromString("https://github.com"))

modules/core/src/test/scala/org/scalasteward/core/io/FileAlgTest.scala

@@ -58,11 +58,8 @@ class FileAlgTest extends FunSuite {
       edited <- fileAlg.editFile(home / "does-not-exists.txt", Some.apply)
     } yield edited).run(MockState.empty).unsafeRunSync()
 
-    val expected = MockState.empty.copy(
-      commands = Vector(
-        List("read", "/tmp/steward/does-not-exists.txt")
-      )
-    )
+    val expected =
+      MockState.empty.copy(commands = Vector(List("read", "/tmp/steward/does-not-exists.txt")))
     assertEquals(state, expected)
     assert(!edited)
   }
@@ -113,6 +110,18 @@ class FileAlgTest extends FunSuite {
     } yield read
     assertEquals(p.unsafeRunSync(), content)
   }
+
+  test("isRegularFile") {
+    val dir = File.temp / "steward" / "regular"
+    val file = dir / "file.txt"
+    val p = for {
+      _ <- ioFileAlg.deleteForce(dir)
+      r1 <- ioFileAlg.isRegularFile(file)
+      _ <- ioFileAlg.writeFileData(dir, FileData("file.txt", "content"))
+      r2 <- ioFileAlg.isRegularFile(file)
+    } yield (r1, r2)
+    assertEquals(p.unsafeRunSync(), (false, true))
+  }
 }
 
 object FileAlgTest {