Merge pull request #2239 from scala-steward-org/topic/scalafmtConf-val

Add val for the name of the scalafmt conf file

Author: fthomas

modules/core/src/main/scala/org/scalasteward/core/io/package.scala

@@ -19,7 +19,7 @@ package org.scalasteward.core
 import better.files.File
 import cats.syntax.all._
 import org.scalasteward.core.data.{GroupId, Update}
-import org.scalasteward.core.scalafmt.{scalafmtArtifactId, scalafmtGroupId}
+import org.scalasteward.core.scalafmt.{scalafmtArtifactId, scalafmtConfName, scalafmtGroupId}
 
 package object io {
   def isSourceFile(update: Update, fileExtensions: Set[String])(file: File): Boolean = {
@@ -32,7 +32,7 @@ package object io {
   ): Boolean =
     () match {
       case _ if isSbtUpdate(update)          => file.name === "build.properties"
-      case _ if isScalafmtCoreUpdate(update) => file.name === ".scalafmt.conf"
+      case _ if isScalafmtCoreUpdate(update) => file.name === scalafmtConfName
       case _                                 => isGenericSourceFile(file, fileExtensions)
     }
 

modules/core/src/main/scala/org/scalasteward/core/scalafmt/ScalafmtAlg.scala

@@ -35,7 +35,7 @@ final class ScalafmtAlg[F[_]](config: Config)(implicit
   def getScalafmtVersion(buildRoot: BuildRoot): F[Option[Version]] =
     for {
       buildRootDir <- workspaceAlg.buildRootDir(buildRoot)
-      scalafmtConfFile = buildRootDir / ".scalafmt.conf"
+      scalafmtConfFile = buildRootDir / scalafmtConfName
       fileContent <- fileAlg.readFile(scalafmtConfFile)
     } yield fileContent.flatMap(parseScalafmtConf)
 

modules/core/src/main/scala/org/scalasteward/core/scalafmt/package.scala

@@ -39,4 +39,6 @@ package object scalafmt {
     Dependency(scalafmtGroupIdBy(version), scalafmtArtifactId, version.value)
 
   val scalafmtBinary: String = "scalafmt"
+
+  val scalafmtConfName = ".scalafmt.conf"
 }

modules/core/src/test/scala/org/scalasteward/core/buildtool/BuildToolDispatcherTest.scala

@@ -11,6 +11,7 @@ import org.scalasteward.core.mock.MockState
 import org.scalasteward.core.mock.MockState.TraceEntry.Cmd
 import org.scalasteward.core.repoconfig.RepoConfig
 import org.scalasteward.core.scalafmt
+import org.scalasteward.core.scalafmt.scalafmtConfName
 import org.scalasteward.core.vcs.data.Repo
 
 class BuildToolDispatcherTest extends FunSuite {
@@ -21,7 +22,7 @@ class BuildToolDispatcherTest extends FunSuite {
     val initial = MockState.empty
       .addFiles(
         repoDir / "project" / "build.properties" -> "sbt.version=1.2.6",
-        repoDir / ".scalafmt.conf" -> "version=2.0.0"
+        repoDir / scalafmtConfName -> "version=2.0.0"
       )
       .unsafeRunSync()
     val (state, deps) =
@@ -46,7 +47,7 @@ class BuildToolDispatcherTest extends FunSuite {
           s";$crossStewardDependencies;$reloadPlugins;$stewardDependencies"
         ),
         Cmd("read", s"$repoDir/project/build.properties"),
-        Cmd("read", s"$repoDir/.scalafmt.conf")
+        Cmd("read", s"$repoDir/$scalafmtConfName")
       )
     )
 

modules/core/src/test/scala/org/scalasteward/core/edit/EditAlgTest.scala

@@ -11,7 +11,7 @@ import org.scalasteward.core.mock.MockContext.context.editAlg
 import org.scalasteward.core.mock.MockState
 import org.scalasteward.core.mock.MockState.TraceEntry.{Cmd, Log}
 import org.scalasteward.core.repoconfig.RepoConfig
-import org.scalasteward.core.scalafmt.scalafmtBinary
+import org.scalasteward.core.scalafmt.{scalafmtBinary, scalafmtConfName}
 import org.scalasteward.core.util.Nel
 import org.scalasteward.core.vcs.data.Repo
 
@@ -60,7 +60,7 @@ class EditAlgTest extends FunSuite {
     val data = RepoData(repo, dummyRepoCache, RepoConfig.empty)
     val repoDir = config.workspace / repo.show
     val update = Update.Single("org.scalameta" % "scalafmt-core" % "2.0.0", Nel.of("2.1.0"))
-    val scalafmtConf = repoDir / ".scalafmt.conf"
+    val scalafmtConf = repoDir / scalafmtConfName
     val scalafmtConfContent = """maxColumn = 100
                                 |version = 2.0.0
                                 |align.openParenCallSite = false

modules/core/src/test/scala/org/scalasteward/core/scalafmt/ScalafmtAlgTest.scala

@@ -14,7 +14,7 @@ class ScalafmtAlgTest extends FunSuite {
     val repo = Repo("fthomas", "scala-steward")
     val buildRoot = BuildRoot(repo, ".")
     val repoDir = config.workspace / repo.owner / repo.repo
-    val scalafmtConf = repoDir / ".scalafmt.conf"
+    val scalafmtConf = repoDir / scalafmtConfName
     val initialState = MockState.empty
       .addFiles(scalafmtConf -> """maxColumn = 100
                                   |version=2.0.0-RC8
@@ -24,7 +24,7 @@ class ScalafmtAlgTest extends FunSuite {
     val (state, maybeVersion) =
       scalafmtAlg.getScalafmtVersion(buildRoot).runSA(initialState).unsafeRunSync()
     val expectedState = initialState.copy(
-      trace = Vector(Cmd("read", s"$repoDir/.scalafmt.conf"))
+      trace = Vector(Cmd("read", scalafmtConf.toString))
     )
 
     assertEquals(maybeVersion, Some(Version("2.0.0-RC8")))
@@ -35,7 +35,7 @@ class ScalafmtAlgTest extends FunSuite {
     val repo = Repo("fthomas", "scala-steward")
     val buildRoot = BuildRoot(repo, ".")
     val repoDir = config.workspace / repo.owner / repo.repo
-    val scalafmtConf = repoDir / ".scalafmt.conf"
+    val scalafmtConf = repoDir / scalafmtConfName
     val initialState = MockState.empty
       .addFiles(scalafmtConf -> """maxColumn = 100
                                   |version="2.0.0-RC8"