Use Blocker for Process#waitFor in slurp (#1902)

fthomas · web-flow · commit f163cc050595 · 2021-01-24T22:10:20.000+01:00
`waitFor` [blocks the calling thread][1] so it is appropriate to evaluate it on the available `Blocker`. [1]: https://docs.oracle.com/javase/8/docs/api/java/lang/Process.html#waitFor--
diff --git a/modules/core/src/main/scala/org/scalasteward/core/io/process.scala b/modules/core/src/main/scala/org/scalasteward/core/io/process.scala
@@ -51,7 +51,7 @@ object process {
             .drain
         }
 
-        val result = readOut >> F.delay(process.waitFor()) >>= { exitValue =>
+        val result = readOut >> blocker.delay(process.waitFor()) >>= { exitValue =>
           if (exitValue === 0) F.pure(buffer.toList)
           else {
             val msg = s"'${showCmd(args)}' exited with code $exitValue"

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ object process {`
`51`	`51`	`.drain`
`52`	`52`	`}`
`53`	`53`
`54`		`- val result = readOut >> F.delay(process.waitFor()) >>= { exitValue =>`
	`54`	`+ val result = readOut >> blocker.delay(process.waitFor()) >>= { exitValue =>`
`55`	`55`	`if (exitValue === 0) F.pure(buffer.toList)`
`56`	`56`	`else {`
`57`	`57`	`val msg = s"'${showCmd(args)}' exited with code $exitValue"`