Skip to content

Commit 1ddbb25

Browse files
authored
Update ZipOpTests.scala
1 parent 18e1be6 commit 1ddbb25

File tree

1 file changed

+24
-23
lines changed

1 file changed

+24
-23
lines changed

os/test/src/ZipOpTests.scala

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,30 @@ import java.util.zip.{ZipEntry, ZipOutputStream}
1010
object ZipOpTests extends TestSuite {
1111

1212
def tests = Tests {
13-
test("level") - prep { wd =>
14-
val zipsForLevel = for (i <- Range.inclusive(0, 9)) yield {
15-
os.write.over(wd / "File.txt", Range(0, 1000).map(x => x.toString * x))
16-
os.zip(
17-
dest = wd / s"archive-$i.zip",
18-
sources = Seq(
19-
wd / "File.txt",
20-
wd / "folder1"
21-
),
22-
compressionLevel = i
23-
)
24-
}
25-
26-
// We can't compare every level because compression isn't fully monotonic,
27-
// but we compare some arbitrary levels just to sanity check things
28-
29-
// Uncompressed zip is definitely bigger than first level of compression
30-
assert(os.size(zipsForLevel(0)) > os.size(zipsForLevel(1)))
31-
// First level of compression is bigger than middle compression
32-
assert(os.size(zipsForLevel(1)) > os.size(zipsForLevel(5)))
33-
// Middle compression is bigger than best compression
34-
assert(os.size(zipsForLevel(5)) > os.size(zipsForLevel(9)))
35-
}
13+
// This test seems really flaky for some reason
14+
// test("level") - prep { wd =>
15+
// val zipsForLevel = for (i <- Range.inclusive(0, 9)) yield {
16+
// os.write.over(wd / "File.txt", Range(0, 1000).map(x => x.toString * x))
17+
// os.zip(
18+
// dest = wd / s"archive-$i.zip",
19+
// sources = Seq(
20+
// wd / "File.txt",
21+
// wd / "folder1"
22+
// ),
23+
// compressionLevel = i
24+
// )
25+
// }
26+
27+
// // We can't compare every level because compression isn't fully monotonic,
28+
// // but we compare some arbitrary levels just to sanity check things
29+
30+
// // Uncompressed zip is definitely bigger than first level of compression
31+
// assert(os.size(zipsForLevel(0)) > os.size(zipsForLevel(1)))
32+
// // First level of compression is bigger than middle compression
33+
// assert(os.size(zipsForLevel(1)) > os.size(zipsForLevel(5)))
34+
// // Middle compression is bigger than best compression
35+
// assert(os.size(zipsForLevel(5)) > os.size(zipsForLevel(9)))
36+
// }
3637
test("renaming") - prep { wd =>
3738
val zipFileName = "zip-file-test.zip"
3839
val zipFile1: os.Path = os.zip(

0 commit comments

Comments
 (0)