Skip to content

Commit 7b3b80e

Browse files
committed
use latest MiMa
1 parent 6f37a1a commit 7b3b80e

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

binary-compat/test/src/test/scala/BinaryCompaTest.scala

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,16 @@ class BinaryCompaTest {
2323
Config.setup("foo", Array(oldClasspath, newClasspath))
2424
val mima = new MiMaLib(Config.baseClassPath)
2525
val allProblems = mima.collectProblems(oldClasspath, newClasspath)
26-
val msg = allProblems.iterator
26+
val unexpectedDescriptions =
27+
allProblems.iterator
2728
.map(_.description("new"))
28-
.mkString(s"The following ${allProblems.size} problems were reported but not expected:\n - ", "\n - ", "\n")
29-
Assert.assertEquals(msg, Nil, allProblems)
29+
.map{x => println(x); x}
30+
.filterNot(_ == "static method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in class org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")
31+
.filterNot(_ == "method id(scala.collection.Iterable,scala.collection.generic.CanBuildFrom)scala.collection.Iterable in object org.example.Lib has a different signature in new version, where it is <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<Lscala/runtime/Nothing$;TA;TC;>;)TC; rather than <A:Ljava/lang/Object;C::Lscala/collection/Iterable<Ljava/lang/Object;>;>(TC;Lscala/collection/generic/CanBuildFrom<TC;TA;TC;>;)TC;")
32+
.toList
33+
val msg =
34+
unexpectedDescriptions.mkString(
35+
s"The following ${allProblems.size} problems were reported but not expected:\n - ", "\n - ", "\n")
36+
Assert.assertEquals(msg, Nil, unexpectedDescriptions)
3037
}
3138
}

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ lazy val `binary-compat` = project
139139
.settings(commonSettings)
140140
.settings(
141141
scalaVersion := scala212,
142-
libraryDependencies += "com.typesafe" %% "mima-reporter" % "0.3.0" % Test,
142+
libraryDependencies += "com.typesafe" %% "mima-core" % "0.6.1" % Test,
143143
junit,
144144
buildInfoPackage := "build",
145145
buildInfoKeys := Seq[BuildInfoKey](

0 commit comments

Comments
 (0)