First draft of add nn quick fix

Author: SuperCl4sh

compiler/src/dotty/tools/dotc/reporting/messages.scala

@@ -295,6 +295,10 @@ extends NotFoundMsg(MissingIdentID) {
 class TypeMismatch(val found: Type, expected: Type, val inTree: Option[untpd.Tree], addenda: => String*)(using Context)
   extends TypeMismatchMsg(found, expected)(TypeMismatchID):
 
+  private var shouldSuggestNN = false
+  // Ensures that shouldSuggestNN will always be correctly computed before `actions` is called
+  msg
+
   def msg(using Context) =
     // replace constrained TypeParamRefs and their typevars by their bounds where possible
     // and the bounds are not f-bounds.
@@ -339,6 +343,7 @@ class TypeMismatch(val found: Type, expected: Type, val inTree: Option[untpd.Tre
     val (found2, expected2) =
       if (found1 frozen_<:< expected1) || reported.fbounded then (found, expected)
       else (found1, expected1)
+    if found2 frozen_<:< OrNull(expected) then shouldSuggestNN = true
     val (foundStr, expectedStr) = Formatting.typeDiff(found2.normalized, expected2.normalized)
     i"""|Found:    $foundStr
         |Required: $expectedStr${reported.notes}"""
@@ -355,6 +360,28 @@ class TypeMismatch(val found: Type, expected: Type, val inTree: Option[untpd.Tre
     val treeStr = inTree.map(x => s"\nTree:\n\n${x.show}\n").getOrElse("")
     treeStr + "\n" + super.explain
 
+  override def actions(using Context) =
+    if shouldSuggestNN then
+      inTree match {
+        case Some(tree) if tree != null =>
+          val content = tree.source.content().slice(tree.srcPos.startPos.start, tree.srcPos.endPos.end).mkString
+          val replacement = tree match
+            case a @ Apply(fun, args) => "(" + content + ").nn"
+            case _ => content
+          List(
+            CodeAction(title = """Add .nn""",
+            description = None,
+            patches = List(
+              ActionPatch(tree.srcPos.sourcePos, replacement)
+            )
+            )
+          )
+        case _ =>
+          List()
+      }
+    else
+      List()
+
 end TypeMismatch
 
 class NotAMember(site: Type, val name: Name, selected: String, proto: Type, addendum: => String = "")(using Context)

compiler/test/dotty/tools/dotc/reporting/CodeActionTest.scala

@@ -136,6 +136,49 @@ class CodeActionTest extends DottyTest:
          afterPhase = "patternMatcher"
       )
 
+  @Test def removeNN =
+    val ctxx = newContext
+    ctxx.setSetting(ctxx.settings.YexplicitNulls, true)
+    checkCodeAction(
+      code =
+        """|val s: String|Null = "foo".nn
+           |""".stripMargin,
+         title = "Remove unnecessary .nn",
+      expected =
+        """|val s: String|Null = "foo"
+           |""".stripMargin,
+      ctxx = ctxx
+      )
+
+
+  @Test def removeNN2 =
+    val ctxx = newContext
+    ctxx.setSetting(ctxx.settings.YexplicitNulls, true)
+    checkCodeAction(
+      code =
+        """val s: String|Null = null.nn
+           |""".stripMargin,
+         title = "Remove unnecessary .nn",
+      expected =
+        """val s: String|Null = null
+           |""".stripMargin,
+      ctxx = ctxx
+      )
+
+  @Test def addNN =
+    val ctxx = newContext
+    ctxx.setSetting(ctxx.settings.YexplicitNulls, true)
+    checkCodeAction(
+      code =
+        """val s: String|Null = ???
+          | val t: String = s""".stripMargin,
+        title = "Add .nn",
+      expected =
+        """val s: String|Null = ???
+          | val t: String = (s).nn""".stripMargin,
+      ctxx = ctxx
+      )
+
   // Make sure we're not using the default reporter, which is the ConsoleReporter,
   // meaning they will get reported in the test run and that's it.
   private def newContext =