refactor version dropdown and text button component

Author: Filip Łukasik

scaladoc/resources/dotty_res/styles/theme/components/button/text-button.css

@@ -2,29 +2,29 @@
   display: flex;
 }
 
-.text-button a {
+.text-button {
   color: var(--action-primary-content-default);
   text-decoration: none;
   cursor: pointer;
 }
 
-.text-button:hover a {
+.text-button:hover {
   color: var(--action-primary-content-hover);
 }
 
-.text-button:active a {
+.text-button:active {
   color: var(--action-primary-content-active);
 }
 
-.text-button.selected a {
+.text-button.selected {
   color: var(--action-primary-content-selected);
 }
 
-.text-button:focus-visible a {
+.text-button:focus-visible {
   box-shadow: 0px 0px 0px 2px var(--focus-default);
 }
 
-.text-button:disabled a {
+.text-button:disabled {
   opacity: 0.5;
 }
 

scaladoc/resources/dotty_res/styles/theme/components/dropdown-menu.css

@@ -10,13 +10,18 @@
   position: absolute;
   padding: calc(3 * var(--base-spacing));
   z-index: 2;
-  top: calc(6 * var(--base-spacing));
 }
 
-/* .dropdown-menu > *:not(:last-child) {
+.dropdown-menu > *:not(:last-child) {
   margin-bottom: calc(2 * var(--base-spacing));
-} */
+}
 
 .dropdown-menu.expanded {
   display: flex;
 }
+
+/* version dropdown */
+#version-dropdown {
+  top: calc(6 * var(--base-spacing));
+  left: calc(34.25 * var(--base-spacing));
+}

scaladoc/src/dotty/tools/scaladoc/renderers/HtmlRenderer.scala

@@ -220,43 +220,29 @@ class HtmlRenderer(rootPackage: Member, members: Map[DRI, Member])(using ctx: Do
             a()(
               args.projectVersion.map(v => div(cls:="projectVersion")(v)).getOrElse("")
             ),
-            div(id := "version-dropdown", cls := "dropdown-menu") (
-              span(cls := "text-button")()
-            )
           ),
+          div(id := "version-dropdown", cls := "dropdown-menu") ()
         ),
          div(cls:="header-container-right")(
           button(id := "search-toggle", cls := "icon-button"),
-          span(cls := "text-button")(
-            a(href := "https://www.scala-lang.org/download/") (
+            a(href := "https://www.scala-lang.org/download/", cls := "text-button") (
               "Download",
-            )
-          ),
-          span(cls := "text-button")(
-            a(href := "https://docs.scala-lang.org/") (
+            ),
+            a(href := "https://docs.scala-lang.org/", cls := "text-button") (
               "Documentation",
-            )
-          ),
-          span(cls := "text-button")(
-            a(href := "https://index.scala-lang.org") (
+            ),
+            a(href := "https://index.scala-lang.org", cls := "text-button") (
               "Libraries",
-            )
-          ),
-          span(cls := "text-button")(
-            a(href := "https://www.scala-lang.org/contribute/") (
+            ),
+            a(href := "https://www.scala-lang.org/contribute/", cls := "text-button") (
               "Contribute",
-            )
-          ),
-          span(cls := "text-button")(
-            a(href := "https://www.scala-lang.org/contribute/") (
+            ),
+            a(href := "https://www.scala-lang.org/contribute/", cls := "text-button") (
               "Blog",
-            )
-          ),
-          span(cls := "text-button")(
-            a(href := "https://www.scala-lang.org/blog/") (
+            ),
+            a(href := "https://www.scala-lang.org/blog/", cls := "text-button") (
               "Community",
-            )
-          ),
+            ),
           button(id := "theme-toggle", cls := "icon-button"),
         ),