BackendInterface: clean-up name handling

- Remove simpleName since it's equivalent to name
- Remove unused fullName(sep: Char)
- Rename fullName to showFullName since it's only used for logging
  statements

Author: smarter

compiler/src/dotty/tools/backend/jvm/BCodeBodyBuilder.scala

@@ -114,7 +114,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
             case POS => () // nothing
             case NEG => bc.neg(resKind)
             case NOT => bc.genPrimitiveArithmetic(Primitives.NOT, resKind)
-            case _ => abort(s"Unknown unary operation: ${fun.symbol.fullName} code: $code")
+            case _ => abort(s"Unknown unary operation: ${fun.symbol.showFullName} code: $code")
           }
 
         // binary operation
@@ -256,7 +256,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
         coercionTo(code)
       }
       else abort(
-        s"Primitive operation not handled yet: ${sym.fullName}(${fun.symbol.simpleName}) at: ${tree.pos}"
+        s"Primitive operation not handled yet: ${sym.showFullName}(${fun.symbol.name}) at: ${tree.pos}"
       )
     }
 
@@ -633,7 +633,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
         val cast = sym match {
           case Object_isInstanceOf => false
           case Object_asInstanceOf => true
-          case _ => abort(s"Unexpected type application $fun[sym: ${sym.fullName}] in: $t")
+          case _ => abort(s"Unexpected type application $fun[sym: ${sym.showFullName}] in: $t")
         }
 
         val l = tpeTK(obj)
@@ -736,7 +736,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
               mkArrayConstructorCall(arr, app, args)
 
             case rt: ClassBType =>
-              assert(classBTypeFromSymbol(ctor.owner) == rt, s"Symbol ${ctor.owner.fullName} is different from $rt")
+              assert(classBTypeFromSymbol(ctor.owner) == rt, s"Symbol ${ctor.owner.showFullName} is different from $rt")
               mnode.visitTypeInsn(asm.Opcodes.NEW, rt.internalName)
               bc dup generatedType
               genLoadArguments(args, paramTKs(app))

compiler/src/dotty/tools/backend/jvm/BTypesFromSymbols.scala

@@ -49,7 +49,7 @@ class BTypesFromSymbols[I <: BackendInterface](val int: I) extends BTypes {
     assert(
       (!primitiveTypeMap.contains(classSym) || isCompilingPrimitive) &&
       (classSym != NothingClass && classSym != NullClass),
-      s"Cannot create ClassBType for special class symbol ${classSym.fullName}")
+      s"Cannot create ClassBType for special class symbol ${classSym.showFullName}")
 
     convertedClasses.getOrElse(classSym, {
       val internalName = classSym.javaBinaryName

compiler/src/dotty/tools/backend/jvm/BackendInterface.scala

@@ -443,9 +443,7 @@ abstract class BackendInterface extends BackendInterfaceDefinitions {
 
   abstract class SymbolHelper {
     // names
-    def fullName(sep: Char): String
-    def fullName: String
-    def simpleName: Name
+    def showFullName: String
     def javaSimpleName: String
     def javaBinaryName: String
     def javaClassName: String

compiler/src/dotty/tools/backend/jvm/DottyBackendInterface.scala

@@ -628,9 +628,7 @@ class DottyBackendInterface(outputDirectory: AbstractFile, val superCallsMap: Ma
 
   implicit def symHelper(sym: Symbol): SymbolHelper = new SymbolHelper {
     // names
-    def fullName(sep: Char): String = sym.showFullName
-    def fullName: String = sym.showFullName
-    def simpleName: Name = sym.name
+    def showFullName: String = sym.showFullName
     def javaSimpleName: String = toDenot(sym).name.mangledString // addModuleSuffix(simpleName.dropLocal)
     def javaBinaryName: String = javaClassName.replace('.', '/') // TODO: can we make this a string? addModuleSuffix(fullNameInternal('/'))
     def javaClassName: String = toDenot(sym).fullName.mangledString // addModuleSuffix(fullNameInternal('.')).toString

compiler/src/dotty/tools/backend/jvm/GenBCode.scala

@@ -207,7 +207,7 @@ class GenBCodePipeline(val int: DottyBackendInterface)(implicit val ctx: Context
           if (claszSymbol.companionClass == NoSymbol) {
             mirrorCodeGen.genMirrorClass(claszSymbol, cunit)
           } else {
-            ctx.log(s"No mirror class for module with linked class: ${claszSymbol.fullName}")
+            ctx.log(s"No mirror class for module with linked class: ${claszSymbol.showFullName}")
             null
           }
         } else null