Module failure

Author: som-snytt

compiler/src/dotty/tools/dotc/transform/Constructors.scala

@@ -75,6 +75,7 @@ class Constructors extends MiniPhase with IdentityDenotTransformer { thisPhase =
              ||
              method.owner.owner == sym.owner && !method.owner.isOneOf(MethodOrLazy)
           )
+          && !sym.owner.is(Module) // lambdalift doesn't transform correctly (to do)
         val inConstructor =
              (method.isPrimaryConstructor || inAnonFunInCtor)
           && ctx.owner.enclosingClass == sym.owner

tests/pos/i22979.scala

@@ -9,3 +9,10 @@ import scala.util.boundary
 
 class Leak()(using @constructorOnly l: boundary.Label[String]):
   Option("stop").foreach(boundary.break(_))
+
+
+class Lapse:
+  def f = Lapse.DefaultSentinelFn()
+object Lapse:
+  private val DefaultSentinel: AnyRef = new AnyRef
+  private val DefaultSentinelFn: () => AnyRef = () => DefaultSentinel

tests/run/i22979/test.scala

@@ -6,8 +6,17 @@ import util.Try
   assert(classOf[Leak].getFields.length == 0)
   //classOf[Leak].getFields.map(_.getName).foreach(println) //DEBUG
   assert(classOf[C].getFields.length == 0)
+  //classOf[Lapse.type].getFields.map(_.getName).foreach(println) //DEBUG
 
 class C:
   private val x = 42
   println(x)
   println(List(27).map(_ + x))
+
+// The easy tweak for lambdas does not work for module owner.
+// The lambdalifted anonfun is not transformed correctly.
+class Lapse:
+  def f = Lapse.DefaultSentinelFn()
+object Lapse:
+  private val DefaultSentinel: AnyRef = new AnyRef
+  private val DefaultSentinelFn: () => AnyRef = () => DefaultSentinel