add more tests

Author: liufengyun

compiler/src/dotty/tools/dotc/transform/IsInstanceOfChecker.scala

@@ -78,10 +78,8 @@ object Checkable {
       debug.println("X : " + X.widen)
 
       !(P1 <:< X.widen) || {
-        // val syms = maximizeType(P1, Psym.pos, fromScala2x = false)
-        isFullyDefined(P1, ForceDegree.noBottom)
         val P2   = replaceBinderMap.apply(P)
-        val res  = P1 <:< P2
+        val res  = isFullyDefined(P1, ForceDegree.noBottom) && P1 <:< P2
         debug.println("P2: " + P2.show)
         debug.println("P1 <:< P2 = " + res)
         res
@@ -96,7 +94,7 @@ object Checkable {
           case defn.ArrayOf(tpE)   => checkable(tpE, tpT)
           case _                   => checkable(defn.AnyType, tpT)
         }
-      case tpe: AppliedType     => !isAbstract && isClassDetermined(tpe)(ctx.fresh.setFreshGADTBounds)
+      case tpe: AppliedType     => !isAbstract && isClassDetermined(tpe)
       case AndType(tp1, tp2)    => checkable(X, tp1) && checkable(X, tp2)
       case OrType(tp1, tp2)     => checkable(X, tp1) && checkable(X, tp2)
       case AnnotatedType(t, an) => an.symbol == defn.UncheckedAnnot || checkable(X, t)

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -190,7 +190,7 @@ class CompilationTests extends ParallelTesting {
     compileFile("tests/neg-custom-args/noimports2.scala", defaultOptions.and("-Yno-imports")) +
     compileFile("tests/neg-custom-args/i3882.scala", allowDeepSubtypes) +
     compileFile("tests/neg-custom-args/i1754.scala", allowDeepSubtypes) +
-    compileDir("tests/neg-custom-args/isInstanceOf", defaultOptions and "-Xfatal-warnings") +
+    compileFilesInDir("tests/neg-custom-args/isInstanceOf", defaultOptions and "-Xfatal-warnings") +
     compileFile("tests/neg-custom-args/i3627.scala", allowDeepSubtypes)
   }.checkExpectedErrors()
 

tests/neg-custom-args/isInstanceOf/gadt.scala

@@ -0,0 +1,40 @@
+sealed trait Exp[T]
+case class Num(n: Int) extends Exp[Int]
+case class Plus(e1: Exp[Int], e2: Exp[Int]) extends Exp[Int]
+case class Var[T](name: String) extends Exp[T]
+case class Lambda[T, U](x: Var[T], e: Exp[U]) extends Exp[T => U]
+case class App[T, U](f: Exp[T => U], e: Exp[T]) extends Exp[U]
+
+abstract class Env { outer =>
+  def apply[T](x: Var[T]): T
+
+  def + [T](xe: (Var[T], T)) = new Env {
+    def apply[T](x: Var[T]): T =
+      if (x == xe._1) xe._2.asInstanceOf[T]
+      else outer(x)
+  }
+}
+
+object Env {
+  val empty = new Env {
+    def apply[T](x: Var[T]): T = ???
+  }
+}
+
+object Test {
+
+  val exp = App(Lambda(Var[Int]("x"), Plus(Var[Int]("x"), Num(1))), Var[Int]("2"))
+
+  def eval[T](e: Exp[T])(env: Env): T = e match {
+    case Num(n) => n
+    case Plus(e1, e2) => eval(e1)(env) + eval(e2)(env)
+    case v: Var[T] => env(v)
+    case Lambda(x: Var[s], e) => ((y: s) => eval(e)(env + (x -> y)))
+    case App(f, e) => eval(f)(env)(eval(e)(env))
+  }
+
+  eval(exp)(Env.empty)
+
+  def foo(x: Any): Boolean =
+    x.isInstanceOf[List[String]]  // error
+}