address review feedback

liufengyun · liufengyun · commit 20448c855796 · 2017-05-15T14:03:14.000+02:00
diff --git a/doc-tool/src/dotty/tools/dottydoc/util/MemberLookup.scala b/doc-tool/src/dotty/tools/dottydoc/util/MemberLookup.scala
@@ -77,7 +77,8 @@ trait MemberLookup {
       case (x :: xs, _) =>
         if (xs.nonEmpty) globalLookup
         else lookup(entity, packages, "scala." + query)
-      case (Nil, _) => ??? // impossible as long as query is not empty
+      case (Nil, _) =>
+        throw new IllegalArgumentException("`query` cannot be empty")
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ trait MemberLookup {`
`77`	`77`	`case (x :: xs, _) =>`
`78`	`78`	`if (xs.nonEmpty) globalLookup`
`79`	`79`	`else lookup(entity, packages, "scala." + query)`
`80`		`- case (Nil, _) => ??? // impossible as long as query is not empty`
	`80`	`+ case (Nil, _) =>`
	`81`	+ throw new IllegalArgumentException("`query` cannot be empty")
`81`	`82`	`}`
`82`	`83`	`}`
`83`	`84`