pr remarks

RoccoMathijn · RoccoMathijn · commit 2685ba99f98c · 2025-01-28T21:07:11.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/typer/RefChecks.scala b/compiler/src/dotty/tools/dotc/typer/RefChecks.scala
@@ -1190,8 +1190,7 @@ object RefChecks {
             }
           }
         .exists
-      if !target.typeSymbol.denot.isOpaqueAlias // Opaque types hide original members so extension is not nullified by the original member
-        && hidden
+      if !target.typeSymbol.isOpaqueAlias && hidden
       then report.warning(ExtensionNullifiedByMember(sym, target.typeSymbol), sym.srcPos)
   end checkExtensionMethods
 
diff --git a/tests/warn/i22233.check b/tests/warn/i22233.check
diff --git a/tests/warns/ext-override.scala b/tests/warns/ext-override.scala
@@ -1,3 +1,5 @@
+package warns
+
 //> using options -Xfatal-warnings
 
 trait Foo[T]:

Original file line number	Diff line number	Diff line change
`@@ -1190,8 +1190,7 @@ object RefChecks {`
`1190`	`1190`	`}`
`1191`	`1191`	`}`
`1192`	`1192`	`.exists`
`1193`		`- if !target.typeSymbol.denot.isOpaqueAlias // Opaque types hide original members so extension is not nullified by the original member`
`1194`		`- && hidden`
	`1193`	`+ if !target.typeSymbol.isOpaqueAlias && hidden`
`1195`	`1194`	`then report.warning(ExtensionNullifiedByMember(sym, target.typeSymbol), sym.srcPos)`
`1196`	`1195`	`end checkExtensionMethods`
`1197`	`1196`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+package warns`
	`2`	`+`
`1`	`3`	`//> using options -Xfatal-warnings`
`2`	`4`
`3`	`5`	`trait Foo[T]:`