Treat new style given syntax without a rhs or template as concrete

odersky · odersky · commit 2cd7028ad57c · 2024-03-29T19:37:31.000+01:00
To make an abstract given with new style syntax, one needs to write
`= deferred`.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -4159,7 +4159,7 @@ object Parsers {
             ValDef(name, parents.head, subExpr())
           else
             DefDef(name, adjustDefParams(joinParams(tparams, vparamss)), parents.head, subExpr())
-        else if (isStatSep || isStatSeqEnd) && parentsIsType then
+        else if (isStatSep || isStatSeqEnd) && parentsIsType && !newSyntaxAllowed then
           if name.isEmpty then
             syntaxError(em"anonymous given cannot be abstract")
           DefDef(name, adjustDefParams(joinParams(tparams, vparamss)), parents.head, EmptyTree)
diff --git a/tests/neg/deferred-givens.scala b/tests/neg/deferred-givens.scala
@@ -1,4 +1,4 @@
-//> using options -YXtypeclass -source future
+//> using options -language:experimental.modularity -source future
 class Ctx
 class Ctx2
 
diff --git a/tests/pos/hylolib/Integers.scala b/tests/pos/hylolib/Integers.scala
@@ -43,4 +43,4 @@ given Int is Comparable:
 
     def lt(other: Int): Boolean = self < other
 
-given Int is StringConvertible {}
+given Int is StringConvertible

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-//> using options -YXtypeclass -source future`
	`1`	`+//> using options -language:experimental.modularity -source future`
`2`	`2`	`class Ctx`
`3`	`3`	`class Ctx2`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -43,4 +43,4 @@ given Int is Comparable:`
`43`	`43`
`44`	`44`	`def lt(other: Int): Boolean = self < other`
`45`	`45`
`46`		`-given Int is StringConvertible {}`
	`46`	`+given Int is StringConvertible`