Skip to content

Commit 373b096

Browse files
committed
fix: disable MiMa for non-bootstrapped scala-library, reference compiler cannot build everything correctly
1 parent fdd15a4 commit 373b096

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

.github/workflows/stdlib.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,7 @@ jobs:
304304
mima-scala-library-nonbootstrapped:
305305
runs-on: ubuntu-latest
306306
needs: scala-library-nonbootstrapped
307+
if: false
307308
steps:
308309
- name: Git Checkout
309310
uses: actions/checkout@v5

project/MiMaFilters.scala

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -559,14 +559,6 @@ object MiMaFilters {
559559
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.StringView.compose"),
560560
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.StringView.andThen"),
561561

562-
// This issue only arise in the non-bootstrapped stdlib
563-
// It has to do with the fact that the special erasure of Pure was handled such as
564-
// `scala.Pure`, not `scala.caps.Pure`. This filter should be removed once we move to 3.8.1
565-
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.Map.from"),
566-
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.SeqMap.from"),
567-
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.mutable.Map.from"),
568-
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.mutable.SeqMap.from"),
569-
570562
// TO INVESTIGATE: This constructor changed, but it is private... why complaining?
571563
ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.collection.immutable.LazyList.this"),
572564
// This one should be fine, public class inside private object

0 commit comments

Comments
 (0)