Use withClient helper in all tests

Author: felixmulder

bot/test/PRServiceTests.scala

@@ -40,10 +40,8 @@ class PRServiceTests extends PullRequestService {
   }
 
   @Test def canGetAllCommitsFromPR = {
-    val httpClient = PooledHttp1Client()
     val issueNbr = 1941 // has 2 commits: https://github.com/lampepfl/dotty/pull/1941/commits
-
-    val List(c1, c2) = getCommits(issueNbr, httpClient).run
+    val List(c1, c2) = withClient(getCommits(issueNbr, _))
 
     assertEquals(
       "Represent untyped operators as Ident instead of Name",
@@ -57,10 +55,8 @@ class PRServiceTests extends PullRequestService {
   }
 
   @Test def canGetMoreThan100Commits = {
-    val httpClient = PooledHttp1Client()
     val issueNbr = 1840 // has >100 commits: https://github.com/lampepfl/dotty/pull/1840/commits
-
-    val numberOfCommits = getCommits(issueNbr, httpClient).run.length
+    val numberOfCommits = withClient(getCommits(issueNbr, _)).length
 
     assert(
       numberOfCommits > 100,
@@ -69,27 +65,24 @@ class PRServiceTests extends PullRequestService {
   }
 
   @Test def canGetComments = {
-    val comments: List[Comment] = withClient(c => getComments(2136, c))
+    val comments: List[Comment] = withClient(getComments(2136, _))
 
     assert(comments.find(_.user.login == Some("odersky")).isDefined,
            "Could not find Martin's comment on PR 2136")
   }
 
   @Test def canCheckCLA = {
-    val httpClient = PooledHttp1Client()
     val validUserCommit = Commit("sha-here", Author(Some("felixmulder")), Author(Some("felixmulder")), CommitInfo(""))
-    val statuses: List[CommitStatus] = checkCLA(validUserCommit :: Nil, httpClient).run
+    val statuses: List[CommitStatus] = withClient(checkCLA(validUserCommit :: Nil, _))
 
     assert(statuses.length == 1, s"wrong number of valid statuses: got ${statuses.length}, expected 1")
-    httpClient.shutdownNow()
   }
 
   @Test def canSetStatus = {
-    val httpClient = PooledHttp1Client()
     val sha = "fa64b4b613fe5e78a5b4185b4aeda89e2f1446ff"
     val status = Invalid("smarter", Commit(sha, Author(Some("smarter")), Author(Some("smarter")), CommitInfo("")))
 
-    val statuses: List[StatusResponse] = sendStatuses(status :: Nil, httpClient).run
+    val statuses: List[StatusResponse] = withClient(sendStatuses(status :: Nil, _))
 
     assert(
       statuses.length == 1,
@@ -100,8 +93,6 @@ class PRServiceTests extends PullRequestService {
       statuses.head.state == "failure",
       s"status set had wrong state, expected 'failure', got: ${statuses.head.state}"
     )
-
-    httpClient.shutdownNow()
   }
 
   @Test def canGetStatus = {