Boost settings tests

Author: som-snytt

compiler/test/dotty/tools/dotc/SettingsTests.scala

@@ -15,13 +15,15 @@ import dotty.tools.io.PlainDirectory
 import dotty.tools.io.Directory
 import dotty.tools.dotc.config.ScalaVersion
 
-import java.nio.file._
+import java.nio.file.*
 
 import org.junit.Test
-import org.junit.Assert._
+import org.junit.Assert.{assertEquals, assertFalse, assertNotEquals, assertTrue}
 import scala.util.Using
 
-class SettingsTests {
+class SettingsTests:
+
+  private val TestCategory = new SettingCategory { def prefixLetter = "T" }
 
   @Test def missingOutputDir: Unit =
     val options = Array("-d", "not_here")
@@ -112,7 +114,7 @@ class SettingsTests {
         false
 
     val default = Settings.defaultState
-    dotty.tools.assertThrows[IllegalArgumentException](checkMessage("found: not an option of type java.lang.String, required: Boolean")) {
+    assertThrows[IllegalArgumentException](checkMessage("found: not an option of type java.lang.String, required: Boolean")) {
       Settings.option.updateIn(default, "not an option")
     }
 
@@ -172,11 +174,12 @@ class SettingsTests {
       )
       assertEquals(expectedErrors, summary.errors)
     }
+  end validateChoices
 
   @Test def `Allow IntSetting's to be set with a colon`: Unit =
     object Settings extends SettingGroup:
       val foo = IntSetting(RootSetting, "foo", "foo", 80)
-    import Settings._
+    import Settings.*
 
     val args = List("-foo:100")
     val summary = processArguments(args, processAll = true)
@@ -191,7 +194,7 @@ class SettingsTests {
       val bar = BooleanSetting(RootSetting, "bar", "bar", true)
       val baz = BooleanSetting(RootSetting, "baz", "baz", false)
       val qux = BooleanSetting(RootSetting, "qux", "qux", false)
-    import Settings._
+    import Settings.*
 
     val args = List("-foo:true", "-bar:false", "-baz", "-qux:true", "-qux:false")
     val summary = processArguments(args, processAll = true)
@@ -210,7 +213,7 @@ class SettingsTests {
         val defaultDir = new PlainDirectory(Directory("."))
         val testOutput = OutputSetting(RootSetting, "testOutput", "testOutput", "", defaultDir)
 
-      import Settings._
+      import Settings.*
 
       Files.write(file, "test".getBytes())
       val fileStateBefore = String(Files.readAllBytes(file))
@@ -230,7 +233,7 @@ class SettingsTests {
         val defaultDir = new PlainDirectory(Directory("."))
         val testOutput = OutputSetting(RootSetting, "testOutput", "testOutput", "", defaultDir, preferPrevious = true)
 
-      import Settings._
+      import Settings.*
 
       Files.write(file1, "test1".getBytes())
       Files.write(file2, "test2".getBytes())
@@ -255,7 +258,7 @@ class SettingsTests {
         val defaultDir = new PlainDirectory(Directory("."))
         val testOutput = OutputSetting(RootSetting, "testOutput", "testOutput", "", defaultDir, preferPrevious = true, deprecation = Deprecation.renamed("XtestOutput"))
 
-      import Settings._
+      import Settings.*
 
       Files.write(file, "test".getBytes())
       val fileStateBefore = String(Files.readAllBytes(file))
@@ -282,7 +285,7 @@ class SettingsTests {
       val phasesSetting = PhasesSetting(RootSetting, "phasesSetting", "phasesSetting", "all")
       val versionSetting= VersionSetting(RootSetting, "versionSetting", "versionSetting")
 
-    import Settings._
+    import Settings.*
     Using.resource(Files.createTempDirectory("testDir")) { dir =>
 
       val args = List(
@@ -323,8 +326,17 @@ class SettingsTests {
 
     }(Files.deleteIfExists(_))
 
+  @Test def `Multi setting with empty default errors if missing`: Unit =
+    object Settings extends SettingGroup:
+      val answers = MultiStringSetting(TestCategory, name="Tanswer", helpArg="your reply", descr="answer me this")
+    import Settings.{answers, processArguments}
+    val summary = processArguments("-Tanswer" :: Nil, processAll = true)
+    assertTrue(summary.warnings.isEmpty)
+    assertFalse(summary.errors.isEmpty)
+    withProcessedArgs(summary):
+      assertTrue(answers.value.isEmpty)
+
   private def withProcessedArgs(summary: ArgsSummary)(f: SettingsState ?=> Unit) = f(using summary.sstate)
 
   extension [T](setting: Setting[T])
     private def value(using ss: SettingsState): T = setting.valueIn(ss)
-}

compiler/test/dotty/tools/dotc/config/ScalaSettingsTests.scala

@@ -299,4 +299,28 @@ class ScalaSettingsTests:
     )
     assertEquals(result, Right(reporting.Action.Error))
 
+  @Test def `Vphases takes optional phase names`: Unit =
+    val settings = ScalaSettings
+    def process(args: List[String]) =
+      val summary = ArgsSummary(settings.defaultState, args, errors = Nil, warnings = Nil)
+      settings.processArguments(summary, processAll = true, skipped = Nil)
+    locally:
+      val summary = process("-Vphases:foo,bar,baz" :: Nil)
+      assertTrue(summary.errors.isEmpty && summary.warnings.isEmpty)
+      assertEquals(List("foo","bar","baz"), settings.Vphases.valueIn(summary.sstate))
+    locally:
+      val summary = process(List("-Vphases","foo","-Vphases","bar","-Vphases","baz"))
+      assertTrue(summary.errors.isEmpty && summary.warnings.isEmpty)
+      assertEquals(List("foo","bar","baz"), settings.Vphases.valueIn(summary.sstate))
+    locally:
+      val summary = process(List("-Vphases","--","foo"))
+      assertTrue(summary.errors.isEmpty && summary.warnings.isEmpty)
+      assertEquals(List("none"), settings.Vphases.valueIn(summary.sstate)) // nonempty default required
+      assertEquals(Some(List("none")), settings.Vphases.userValueIn(summary.sstate)) // nonempty default required
+    locally:
+      val summary = process(Nil)
+      assertTrue(summary.errors.isEmpty && summary.warnings.isEmpty)
+      assertEquals(List("none"), settings.Vphases.valueIn(summary.sstate)) // nonempty default required
+      assertEquals(None, settings.Vphases.userValueIn(summary.sstate))
+
 end ScalaSettingsTests