Always print boxes (for now)

It's a necessary measure to diagnose mishandlings of boxes faster.

Author: odersky

compiler/src/dotty/tools/dotc/cc/Setup.scala

@@ -339,8 +339,8 @@ extends tpd.TreeTraverser:
       then transformInferredType(tree.tpe, boxed)
       else transformExplicitType(tree.tpe, boxed))
 
-  private def updateInfo(sym: Symbol, tpe: Type)(using Context) =
-    sym.updateInfoBetween(preRecheckPhase, thisPhase, tpe)
+  private def updateInfo(sym: Symbol, info: Type)(using Context) =
+    sym.updateInfoBetween(preRecheckPhase, thisPhase, info)
 
   def traverse(tree: Tree)(using Context): Unit =
     tree match

compiler/src/dotty/tools/dotc/printing/PlainPrinter.scala

@@ -202,7 +202,7 @@ class PlainPrinter(_ctx: Context) extends Printer {
         }.close
       case tp @ EventuallyCapturingType(parent, refs) =>
         def box =
-          Str("box ") provided tp.isBoxed && ctx.settings.YccDebug.value
+          Str("box ") provided tp.isBoxed //&& ctx.settings.YccDebug.value
         if printDebug && !refs.isConst then
           changePrec(GlobalPrec)(box ~ s"$refs " ~ toText(parent))
         else if ctx.settings.YccDebug.value then

tests/neg-custom-args/captures/capt1.check

@@ -41,6 +41,6 @@
 31 |  val z2 = h[() -> Cap](() => x)(() => C())  // error
    |                        ^^^^^^^
    |                        Found:    {x} () -> Cap
-   |                        Required: () -> Cap
+   |                        Required: () -> box {*} C
    |
    | longer explanation available when compiling with `-explain`

tests/neg-custom-args/captures/real-try.check

@@ -19,5 +19,5 @@
 -- Error: tests/neg-custom-args/captures/real-try.scala:30:4 -----------------------------------------------------------
 30 |  b.x // error
    |  ^^^
-   |  The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |  The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.

tests/neg-custom-args/captures/try.check

@@ -3,7 +3,7 @@
 23 |    (x: CanThrow[Exception]) => x
 24 |  }{ // error
    |          ^
-   |          The expression's type {*} CT[Exception] is not allowed to capture the root capability `*`.
+   |          The expression's type box {*} CT[Exception] is not allowed to capture the root capability `*`.
    |          This usually means that a capability persists longer than its allowed lifetime.
 25 |    (ex: Exception) => ???
 26 |  }
@@ -24,7 +24,7 @@
 38 |        22
 39 |  } {  // error
    |           ^
-   |           The expression's type {*} () -> Int is not allowed to capture the root capability `*`.
+   |           The expression's type box {*} () -> Int is not allowed to capture the root capability `*`.
    |           This usually means that a capability persists longer than its allowed lifetime.
 40 |    (ex: Exception) => () => 22
 41 |  }
@@ -36,7 +36,7 @@
 50 |      22
 51 |} {  // error
    |             ^
-   |             The expression's type {*} () -> Int is not allowed to capture the root capability `*`.
+   |             The expression's type box {*} () -> Int is not allowed to capture the root capability `*`.
    |             This usually means that a capability persists longer than its allowed lifetime.
 52 |  (ex: Exception) => () => 22
 53 |}

tests/neg-custom-args/captures/usingLogFile.check

@@ -1,35 +1,35 @@
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:23:27 ------------------------------------------------------
 23 |  val later = usingLogFile { f => () => f.write(0) } // error
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |              The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |              The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |              This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:29:9 -------------------------------------------------------
 29 |  later2.x()  // error
    |  ^^^^^^^^
-   |  The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |  The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:31:6 -------------------------------------------------------
 31 |  var later3: () => Unit = () => ()  // error
    |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |  The mutable variable's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |  The mutable variable's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:37:9 -------------------------------------------------------
 37 |  later4.x() // error
    |  ^^^^^^^^
-   |  The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |  The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:47:27 ------------------------------------------------------
 47 |  val later = usingLogFile { f => () => f.write(0) } // error
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |              The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |              The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |              This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:62:25 ------------------------------------------------------
 62 |    val later = usingFile("out", f => (y: Int) => xs.foreach(x => f.write(x + y))) // error
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |                The expression's type {*} (x$0: Int) -> Unit is not allowed to capture the root capability `*`.
-   |                This usually means that a capability persists longer than its allowed lifetime.
+   |             The expression's type box {*} (x$0: Int) -> Unit is not allowed to capture the root capability `*`.
+   |             This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/usingLogFile.scala:71:25 ------------------------------------------------------
 71 |    val later = usingFile("logfile", usingLogger(_, l => () => l.log("test"))) // error
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |                The expression's type {*} () -> Unit is not allowed to capture the root capability `*`.
+   |                The expression's type box {*} () -> Unit is not allowed to capture the root capability `*`.
    |                This usually means that a capability persists longer than its allowed lifetime.

tests/neg-custom-args/captures/vars.check

@@ -8,17 +8,17 @@
 -- Error: tests/neg-custom-args/captures/vars.scala:13:6 ---------------------------------------------------------------
 13 |  var a: String => String = f // error
    |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |  The mutable variable's type {*} String -> String is not allowed to capture the root capability `*`.
+   |  The mutable variable's type box {*} String -> String is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/vars.scala:15:4 ---------------------------------------------------------------
 15 |  b.head // error
    |  ^^^^^^
-   |  The expression's type {*} String -> String is not allowed to capture the root capability `*`.
+   |  The expression's type box {*} String -> String is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 -- Error: tests/neg-custom-args/captures/vars.scala:30:8 ---------------------------------------------------------------
 30 |  local { cap3 => // error
    |  ^
-   |  The expression's type {*} (x$0: ? String) -> ? String is not allowed to capture the root capability `*`.
+   |  The expression's type box {*} (x$0: ? String) -> ? String is not allowed to capture the root capability `*`.
    |  This usually means that a capability persists longer than its allowed lifetime.
 31 |    def g(x: String): String = if cap3 == cap3 then "" else "a"
 32 |    g