Skip to content

Commit 5a3ad0d

Browse files
committed
Add reference to issue with union types
1 parent cd56de3 commit 5a3ad0d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

compiler/src/dotty/tools/dotc/core/Signature.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ case class Signature(paramsSig: List[ParamSig], resSig: TypeName) {
7676
else if (!this.paramsSig.hasSameLengthAs(that.paramsSig)) that
7777
else {
7878
val mapped = Signature(
79-
// DOTTY: we shouldn't have to explicitly pass a type argument to `update`
79+
// DOTTY: we shouldn't have to explicitly pass a type argument to `update`,
80+
// see https://github.com/lampepfl/dotty/issues/4867
8081
this.paramsSig.zipWithConserve(that.paramsSig)(update[ParamSig]),
8182
update(this.resSig, that.resSig))
8283
if (mapped == this) this else mapped

compiler/src/dotty/tools/dotc/core/tasty/TastyUnpickler.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ class TastyUnpickler(reader: TastyReader) {
6666
case SIGNED =>
6767
val original = readName()
6868
val result = readName().toTypeName
69-
// DOTTY: we shouldn't have to give an explicit type to paramsSig
69+
// DOTTY: we shouldn't have to give an explicit type to paramsSig,
70+
// see https://github.com/lampepfl/dotty/issues/4867
7071
val paramsSig: List[Signature.ParamSig] = until(end)(readParamSig())
7172
val sig = Signature(paramsSig, result)
7273
SignedName(original, sig)

0 commit comments

Comments
 (0)