Get rid of FullyCompleted flag

Author: odersky

compiler/src/dotty/tools/dotc/core/Flags.scala

@@ -349,9 +349,6 @@ object Flags {
   /** A bridge method. Set by Erasure */
   final val Bridge = termFlag(34, "<bridge>")
 
-  /** All class attributes are fully defined */
-  final val FullyCompleted = typeFlag(34, "<fully-completed>")
-
   /** Symbol is a Java varargs bridge */ // (needed?)
   final val VBridge = termFlag(35, "<vbridge>") // TODO remove
 

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -1334,23 +1334,6 @@ object SymDenotations {
         NoSymbol
     }
 
-    /** The denotation is fully completed: all attributes are fully defined.
-     *  ClassDenotations compiled from source are first completed, then fully completed.
-     *  Packages are never fully completed since members can be added at any time.
-     *  @see Namer#ClassCompleter
-     */
-    private[core] def isFullyCompleted(implicit ctx: Context): Boolean = {
-      def isFullyCompletedRef(tp: TypeRef) = tp.denot match {
-        case d: ClassDenotation => d.isFullyCompleted
-        case _ => false
-      }
-      def testFullyCompleted =
-        if (classParents.isEmpty) !is(Package) && symbol.eq(defn.AnyClass)
-        else classParents.forall(isFullyCompletedRef)
-      flagsUNSAFE.is(FullyCompleted) ||
-        isCompleted && testFullyCompleted && { setFlag(FullyCompleted); true }
-    }
-
    // ------ class-specific operations -----------------------------------
 
     private[this] var myThisType: Type = null
@@ -1542,7 +1525,7 @@ object SymDenotations {
         var denots: PreDenotation = memberCache lookup name
         if (denots == null) {
           denots = computeNPMembersNamed(name, inherited)
-          if (isFullyCompleted) memberCache.enter(name, denots)
+          memberCache.enter(name, denots)
         } else if (Config.checkCacheMembersNamed) {
           val denots1 = computeNPMembersNamed(name, inherited)
           assert(denots.exists == denots1.exists, s"cache inconsistency: cached: $denots, computed $denots1, name = $name, owner = $this")