Tastydoc: update collection usage

Author: abgruszecki

tastydoc/src/dotty/tastydoc/TastyExtractor.scala

@@ -11,7 +11,7 @@ trait TastyExtractor extends TastyTypeConverter with CommentParser with CommentC
     import reflect.{given, _}
 
     val pathArray = symbol.show.split("\\.") // NOTE: this should print w/o colors, inspect afterwards
-    pathArray.view(0, pathArray.length - 1).toList
+    pathArray.iterator.slice(0, pathArray.length - 1).toList
   }
 
   def extractModifiers(reflect: Reflection)(flags: reflect.Flags, privateWithin: Option[reflect.Type], protectedWithin: Option[reflect.Type]) : (List[String], Option[Reference], Option[Reference]) = {

tastydoc/src/dotty/tastydoc/comment/BodyEntities.scala

@@ -1,7 +1,7 @@
 package dotty.tastydoc
 package comment
 
-import scala.collection._
+import scala.collection.{Seq => _, _}
 import representations._
 
 /** A body of text. A comment has a single body, which is composed of

tastydoc/src/dotty/tastydoc/comment/Comment.scala

@@ -81,8 +81,8 @@ trait MarkupConversion[T](packages: Map[String, EmulatedPackageRepresentation])
     see                     = filterEmpty(parsed.see).map(markupToMarkdown),
     result                  = single("@result", parsed.result).map(markupToMarkdown),
     throws                  = linkedExceptions(parsed.throws),
-    valueParams             = filterEmpty(parsed.valueParams).mapValues(markupToMarkdown),
-    typeParams              = filterEmpty(parsed.typeParams).mapValues(markupToMarkdown),
+    valueParams             = filterEmpty(parsed.valueParams).mapValues(markupToMarkdown).toMap,
+    typeParams              = filterEmpty(parsed.typeParams).mapValues(markupToMarkdown).toMap,
     version                 = single("@version", parsed.version).map(markupToMarkdown),
     since                   = single("@since", parsed.since).map(markupToMarkdown),
     todo                    = filterEmpty(parsed.todo).map(markupToMarkdown),
@@ -91,9 +91,9 @@ trait MarkupConversion[T](packages: Map[String, EmulatedPackageRepresentation])
     example                 = filterEmpty(parsed.example).map(markupToMarkdown),
     constructor             = single("@constructor", parsed.constructor).map(markupToMarkdown),
     group                   = single("@group", parsed.group).map(markupToMarkdown),
-    groupDesc               = filterEmpty(parsed.groupDesc).mapValues(markupToMarkdown),
-    groupNames              = filterEmpty(parsed.groupNames).mapValues(markupToMarkdown),
-    groupPrio               = filterEmpty(parsed.groupPrio).mapValues(markupToMarkdown),
+    groupDesc               = filterEmpty(parsed.groupDesc).mapValues(markupToMarkdown).toMap,
+    groupNames              = filterEmpty(parsed.groupNames).mapValues(markupToMarkdown).toMap,
+    groupPrio               = filterEmpty(parsed.groupPrio).mapValues(markupToMarkdown).toMap,
     hideImplicitConversions = filterEmpty(parsed.hideImplicitConversions).map(markupToMarkdown)
   )
 }
@@ -124,16 +124,16 @@ extends MarkupConversion[MarkdownNode](packages) {
       .map(stringToMarkup)
 
   def filterEmpty(xs: Map[String, String]) =
-    xs.mapValues(_.trim)
+    xs.mapValues(_.trim).toMap
       .filterNot { case (_, v) => v.isEmpty }
-      .mapValues(stringToMarkup)
+      .mapValues(stringToMarkup).toMap
 }
 
 case class WikiComment(ent: Representation, parsed: ParsedComment, packages: Map[String, EmulatedPackageRepresentation])
 extends MarkupConversion[Body](packages) {
 
   def filterEmpty(xs: Map[String,String]) =
-    xs.mapValues(_.toWiki(ent, packages))
+    xs.mapValues(_.toWiki(ent, packages)).toMap
       .filterNot { case (_, v) => v.blocks.isEmpty }
 
   def filterEmpty(xs: List[String]) =
@@ -151,7 +151,7 @@ extends MarkupConversion[Body](packages) {
   }
 
   def linkedExceptions(m: Map[String, String]) = {
-    m.mapValues(_.toWiki(ent, packages)).map { case (targetStr, body) =>
+    m.mapValues(_.toWiki(ent, packages)).toMap.map { case (targetStr, body) =>
       val link = lookup(Some(ent), packages, targetStr)
       val newBody = body match {
         case Body(List(Paragraph(Chain(content)))) =>

tastydoc/src/dotty/tastydoc/comment/WikiParser.scala

@@ -90,7 +90,7 @@ private[comment] final class WikiParser(
         line = listLine(indent, style)
       }
       val constructor = listStyles(style)
-      constructor(lines)
+      constructor(lines.toList)
     }
 
     val indent = countWhitespace