Merge branch 'master' into ct_ops_expansion

Author: OlivierBlanvillain

.github/ISSUE_TEMPLATE/bug.md

@@ -14,6 +14,12 @@ If you're not sure what version you're using, run `print scalaVersion` from sbt
 
 ## Minimized code
 
+<!--
+This code should be self contained, compilable (with possible failures) and as small as possible.
+
+Ideally, we should be able to just copy this code in a file and run `scalac` (and maybe `scala`) to reproduce the issue.
+-->
+
 ```Scala
 println("hello, world")
 ```

.github/ISSUE_TEMPLATE/crash.md

@@ -14,6 +14,12 @@ If you're not sure what version you're using, run `print scalaVersion` from sbt
 
 ## Minimized code
 
+<!--
+This code should be self contained, compilable (with possible failures) and as small as possible.
+
+Ideally, we should be able to just copy this code in a file and run `scalac` (and maybe `scala`) to reproduce the issue.
+-->
+
 ```Scala
 println("hello, world")
 ```

.github/ISSUE_TEMPLATE/syntax-highlight.md

@@ -1,10 +1,13 @@
 ---
 name: Syntax highlighting
-about: Please create a syntax highlighting issue here https://github.com/scala/vscode-scala-syntax/issues
+about: ''
 title: ''
 labels: ''
 assignees: ''
 
 ---
 
-Please create a syntax highlighting issue here: [scala/vscode-scala-syntax](https://github.com/scala/vscode-scala-syntax/issues).
+Please create a syntax highlighting issue here
+* VS Code / GitHub: https://github.com/scala/vscode-scala-syntax/issues
+* IntelliJ: https://youtrack.jetbrains.com/issues/SCL?q=tag:%20%7BScala%203%7D%20tag:%20%7BSyntax%20Highlighting%7D
+* highlight.js: https://github.com/highlightjs/highlight.js/issues

.gitmodules

@@ -213,3 +213,6 @@
 [submodule "community-build/community-projects/scala-java8-compat"]
 	path = community-build/community-projects/scala-java8-compat
 	url = https://github.com/dotty-staging/scala-java8-compat.git
+[submodule "community-build/community-projects/specs2"]
+	path = community-build/community-projects/specs2
+	url = https://github.com/dotty-staging/specs2.git

README.md

@@ -3,7 +3,7 @@ Dotty
 [![Dotty CI](https://github.com/lampepfl/dotty/workflows/Dotty/badge.svg?branch=master)](https://github.com/lampepfl/dotty/actions?query=branch%3Amaster)
 [![Join the chat at https://gitter.im/scala/scala](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/scala/scala?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-* [Homepage](http://dotty.epfl.ch)
+* [Homepage](https://dotty.epfl.ch)
 * [Documentation](https://dotty.epfl.ch/docs)
 
 Try it out

community-build/community-projects/specs2

@@ -731,6 +731,13 @@ object projects:
     dependencies = List(scalaJava8Compat, scalatest)
   )
 
+  lazy val specs2 = SbtCommunityProject(
+    project = "specs2",
+    sbtTestCommand = "core/testOnly -- exclude ci",
+    sbtPublishCommand = "core/publishLocal",
+    dependencies = List()
+  )
+
 end projects
 
 def allProjects = List(
@@ -809,6 +816,7 @@ def allProjects = List(
   projects.fs2,
   projects.libretto,
   projects.jacksonModuleScala,
+  projects.specs2,
 )
 
 lazy val projectMap = allProjects.groupBy(_.project)

community-build/src/scala/dotty/communitybuild/projects.scala

@@ -91,6 +91,7 @@ class CommunityBuildTestC:
   @Test def sconfig = projects.sconfig.run()
   @Test def shapeless = projects.shapeless.run()
   @Test def sourcecode = projects.sourcecode.run()
+  @Test def specs2 = projects.specs2.run()
   @Test def stdLib213 = projects.stdLib213.run()
   @Test def ujson = projects.ujson.run()
   @Test def upickle = projects.upickle.run()

community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala

@@ -4706,7 +4706,7 @@ object JSCodeGen {
       if (!overloads.isOverloaded)
         overloads.symbol
       else
-        overloads.suchThat(_.is(HasDefaultParams)).symbol
+        overloads.suchThat(_.is(HasDefaultParams, butNot = Bridge)).symbol
     }
   }
 

compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala

@@ -1410,29 +1410,6 @@ object desugar {
     FunctionWithMods(params, body, Modifiers(mods))
   }
 
-  /** Add annotation to tree:
-   *      tree @fullName
-   *
-   *  The annotation is usually represented as a TypeTree referring to the class
-   *  with the given name `fullName`. However, if the annotation matches a file name
-   *  that is still to be entered, the annotation is represented as a cascade of `Selects`
-   *  following `fullName`. This is necessary so that we avoid reading an annotation from
-   *  the classpath that is also compiled from source.
-   */
-  def makeAnnotated(fullName: String, tree: Tree)(using Context): Annotated = {
-    val parts = fullName.split('.')
-    val ttree = typerPhase match {
-      case phase: TyperPhase if phase.stillToBeEntered(parts.last) =>
-        val prefix =
-          parts.init.foldLeft(Ident(nme.ROOTPKG): Tree)((qual, name) =>
-            Select(qual, name.toTermName))
-        Select(prefix, parts.last.toTypeName)
-      case _ =>
-        TypeTree(requiredClass(fullName).typeRef)
-    }
-    Annotated(tree, New(ttree, Nil))
-  }
-
   private def derivedValDef(original: Tree, named: NameTree, tpt: Tree, rhs: Tree, mods: Modifiers)(using Context) = {
     val vdef = ValDef(named.name.asTermName, tpt, rhs)
       .withMods(mods)