Rewrite resolveThis; removed assertions

Author: EnzeXing

compiler/src/dotty/tools/dotc/transform/init/Objects.scala

@@ -287,11 +287,22 @@ class Objects(using Context @constructorOnly):
     def toScopeSet: ScopeSet = ScopeSet(values.asInstanceOf[Set[Scope]])
 
   case class ScopeSet(scopes: Set[Scope]):
-    assert(scopes.forall(_.isRef) || scopes.forall(_.isEnv), "All scopes should have the same type!")
+    // assert(scopes.forall(_.isRef) || scopes.forall(_.isEnv), "All scopes should have the same type!")
+
+    def isRefSet = scopes.forall(_.isRef)
+
+    def isEnvSet = scopes.forall(_.isEnv)
 
     def show(using Context) = scopes.map(_.show).mkString("[", ",", "]")
 
-    def toValueSet: ValueSet = ValueSet(scopes.asInstanceOf[Set[ValueElement]])
+    def toValueSet: ValueSet =
+      assert(isRefSet, "Cannot convert scopeSet " + this.show + "to ValueSet!")
+      ValueSet(scopes.asInstanceOf[Set[ValueElement]])
+
+    def partitionByClass(target: ClassSymbol): (ScopeSet, ScopeSet) =
+      // assert(isRefSet, "Invalid partition on scopeSet " + this.show)
+      val (matchSet, unmatchSet) = scopes.partition(s => s.isRef && s.asRef.klass == target)
+      (ScopeSet(matchSet), ScopeSet(unmatchSet))
 
     def lookupSymbol(sym: Symbol)(using Heap.MutableData) = scopes.map(_.valValue(sym)).join
 
@@ -728,6 +739,11 @@ class Objects(using Context @constructorOnly):
           case fun: Fun =>
             if klass.isOneOf(AbstractOrTrait) && klass.baseClasses.exists(defn.isFunctionClass) then fun else Bottom
 
+  extension (thisV: ThisValue)
+    def toValueSet: ValueSet = thisV match
+      case ref: Ref => ValueSet(Set(ref))
+      case vs: ValueSet => vs
+
   given Join[ScopeSet] with
     extension (a: ScopeSet)
       def join(b: ScopeSet): ScopeSet = ScopeSet(a.scopes ++ b.scopes)
@@ -870,6 +886,7 @@ class Objects(using Context @constructorOnly):
           val cls = target.owner.enclosingClass.asClass
           val ddef = target.defTree.asInstanceOf[DefDef]
           val meth = ddef.symbol
+          // println("Before resolving environment, cls = " + cls + ", meth = " + meth)
           val (thisV : ThisValue, outerEnv) =
             if meth.owner.enclosingMethod == cls.primaryConstructor then
               // meth is top-level method, outer is a ref
@@ -1377,7 +1394,7 @@ class Objects(using Context @constructorOnly):
           case OuterSelectName(_, _) =>
             val current = qualifier.tpe.classSymbol
             val target = expr.tpe.widenSingleton.classSymbol.asClass
-            withTrace(trace2) { resolveThis(target, qual) }
+            withTrace(trace2) { resolveThis(target, qual.asInstanceOf[ThisValue]) }
           case _ =>
             withTrace(trace2) { select(qual, expr.symbol, receiver = qualifier.tpe) }
 
@@ -1927,19 +1944,15 @@ class Objects(using Context @constructorOnly):
    * @param scopeSet   The scopes as the starting point.
    */
   def resolveThisRecur(target: ClassSymbol, scopeSet: ScopeSet): Contextual[ValueSet] =
+    // println("scopeSet = " + scopeSet)
     if scopeSet == Env.NoEnv then
       Bottom
+    else if scopeSet.isRefSet then
+      val (matchSet, unmatchSet) = scopeSet.partitionByClass(target)
+      val resolveUnmatchSet = resolveThisRecur(target, unmatchSet.outers)
+      matchSet.toValueSet.join(resolveUnmatchSet).asInstanceOf[ValueSet]
     else
-      val head = scopeSet.scopes.head
-      if head.isInstanceOf[Ref] then
-        val klass = head.asInstanceOf[Ref].klass
-        assert(scopeSet.scopes.forall(_.asInstanceOf[Ref].klass == klass), "Multiple possible outer class?")
-        if klass == target then
-          scopeSet.toValueSet
-        else
-          resolveThisRecur(target, scopeSet.outers)
-      else
-        resolveThisRecur(target, scopeSet.outers)
+      resolveThisRecur(target, scopeSet.outers)
 
   /** Resolve C.this that appear in `D.this`
    *
@@ -1950,7 +1963,7 @@ class Objects(using Context @constructorOnly):
    * Object access elision happens when the object access is used as a prefix
    * in `new o.C` and `C` does not need an outer.
    */
-  def resolveThis(target: ClassSymbol, thisV: Value, elideObjectAccess: Boolean = false): Contextual[ValueSet] = log("resolveThis target = " + target.show + ", this = " + thisV.show, printer, (_: Value).show) {
+  def resolveThis(target: ClassSymbol, thisV: ThisValue, elideObjectAccess: Boolean = false): Contextual[ValueSet] = log("resolveThis target = " + target.show + ", this = " + thisV.show, printer, (_: Value).show) {
     if target.is(Flags.Package) then
       val error = "[Internal error] target cannot be packages, target = " + target + Trace.show
       report.warning(error, Trace.position)
@@ -1960,7 +1973,7 @@ class Objects(using Context @constructorOnly):
       if elideObjectAccess then ValueSet(Set(res))
       else ValueSet(Set(accessObject(target)))
     else
-      thisV match
+      val resolveResult = thisV match
         case Bottom => Bottom
         case ref: Ref =>
           resolveThisRecur(target, ScopeSet(Set(ref)))
@@ -1969,6 +1982,11 @@ class Objects(using Context @constructorOnly):
         case _ =>
           report.warning("[Internal error] unexpected thisV = " + thisV + ", target = " + target.show + Trace.show, Trace.position)
           Bottom
+      if resolveResult == Bottom && thisV.filterClass(target) == thisV then
+        // `target` is not an outer class, but a parent class
+        thisV.toValueSet
+      else
+        resolveResult
   }
 
   /** Compute the outer value that corresponds to `tref.prefix`

compiler/test/dotc/neg-init-global-scala2-library-tasty.excludelist

@@ -15,6 +15,4 @@ global-list.scala
 t5366.scala
 mutable-read7.scala
 t9115.scala
-Color.scala
-unapplySeq-implicit-arg2.scala
-unapplySeq-implicit-arg3.scala
+Color.scala

tests/init-global/pos/virtual-method.scala

@@ -0,0 +1,19 @@
+abstract class T {
+  def foo() = {
+    def bar() = 5
+    bar()
+  }
+}
+
+class A extends T {}
+class B extends T {}
+class C extends T {}
+
+object O {
+  val a = new A
+  val b = new B
+  val c = new C
+  val d = a.foo()
+  val e = b.foo()
+  val f = c.foo()
+}

tests/init-global/warn/resolve-parent-this.check

@@ -0,0 +1,8 @@
+-- Warning: tests/init-global/warn/resolve-parent-this.scala:7:21 ------------------------------------------------------
+7 |  val a: Int = foo().a // warn
+  |               ^^^^^^^
+  |               Access uninitialized field value a. Calling trace:
+  |               ├── object O extends Delegate {	[ resolve-parent-this.scala:6 ]
+  |               │   ^
+  |               └── val a: Int = foo().a // warn	[ resolve-parent-this.scala:7 ]
+  |                                ^^^^^^^

tests/init-global/warn/resolve-parent-this.scala

@@ -0,0 +1,8 @@
+class Delegate {
+  def foo() = f
+  val f: O.type = O
+}
+
+object O extends Delegate {
+  val a: Int = foo().a // warn
+}