Drop StrictFactory and capture check library-js version of Array instead

Without the capture-checked Array, Factory[Array] cannot be proven strict.

Author: natsukagami

library-js/src/scala/Array.scala

@@ -12,6 +12,8 @@
 
 package scala
 
+import language.experimental.captureChecking
+
 //import scala.collection.generic._
 import scala.collection.{Factory, immutable, mutable}
 import mutable.ArrayBuilder
@@ -61,7 +63,7 @@ object Array {
   implicit def toFactory[A : ClassTag](dummy: Array.type): Factory[A, Array[A]] = new ArrayFactory(dummy)
   @SerialVersionUID(3L)
   private class ArrayFactory[A : ClassTag](dummy: Array.type) extends Factory[A, Array[A]] with Serializable {
-    def fromSpecific(it: IterableOnce[A]): Array[A] = Array.from[A](it)
+    def fromSpecific(it: IterableOnce[A]^): Array[A] = Array.from[A](it)
     def newBuilder: mutable.Builder[A, Array[A]] = Array.newBuilder[A]
   }
 
@@ -70,7 +72,7 @@ object Array {
    */
   def newBuilder[T](implicit t: ClassTag[T]): ArrayBuilder[T] = ArrayBuilder.make[T](using t)
 
-  def from[A : ClassTag](it: IterableOnce[A]): Array[A] = {
+  def from[A: ClassTag](it: IterableOnce[A]^): Array[A] = {
     val n = it.knownSize
     if (n > -1) {
       val elements = new Array[A](n)
@@ -656,7 +658,7 @@ object Array {
  *  @define collectExample
  *  @define undefinedorder
  */
-final class Array[T](_length: Int) extends java.io.Serializable with java.lang.Cloneable {
+final class Array[T](_length: Int) extends java.io.Serializable with java.lang.Cloneable { self =>
 
   /** The length of the array */
   def length: Int = throw new Error()

library/src/scala/collection/Factory.scala

@@ -46,16 +46,11 @@ trait Factory[-A, +C] extends Any { self =>
   def newBuilder: Builder[A, C]
 }
 
-/** A strict version of [[Factory]], where the returned collection from [[fromSpecific]] do not capture its input. */
-trait StrictFactory[-A, +C] extends Factory[A, C] {
-  override def fromSpecific(it: IterableOnce[A]^): C
-}
-
 object Factory {
 
-  implicit val stringFactory: StrictFactory[Char, String] = new StringFactory
+  implicit val stringFactory: Factory[Char, String] = new StringFactory
   @SerialVersionUID(3L)
-  private class StringFactory extends StrictFactory[Char, String] with Serializable {
+  private class StringFactory extends Factory[Char, String] with Serializable {
     def fromSpecific(it: IterableOnce[Char]^): String = {
       val b = new mutable.StringBuilder(scala.math.max(0, it.knownSize))
       b ++= it
@@ -64,9 +59,9 @@ object Factory {
     def newBuilder: Builder[Char, String] = new mutable.StringBuilder()
   }
 
-  implicit def arrayFactory[A: ClassTag]: StrictFactory[A, Array[A]] = new ArrayFactory[A]
+  implicit def arrayFactory[A: ClassTag]: Factory[A, Array[A]] = new ArrayFactory[A]
   @SerialVersionUID(3L)
-  private class ArrayFactory[A: ClassTag] extends StrictFactory[A, Array[A]] with Serializable {
+  private class ArrayFactory[A: ClassTag] extends Factory[A, Array[A]] with Serializable {
     def fromSpecific(it: IterableOnce[A]^): Array[A] = {
       val b = newBuilder
       b.sizeHint(it, delta = 0)