Remove Toolbox.make parameterless variant

Bail out on trying to figure out the class loader and force the user to provide it.
As it was done in Scala 2.

Author: nicolasstucki

compiler/test-resources/repl/i6007

@@ -1,4 +1,4 @@
-scala> implicit def toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
+scala> implicit def toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
 def toolbox: quoted.Toolbox
 scala> val v = '{ (if true then Some(1) else None).map(v => v+1) }
 val v: quoted.Expr[Option[Int]] = Expr(<pickled tasty>)

library/src/scala/quoted/Toolbox.scala

@@ -2,7 +2,7 @@ package scala.quoted
 
 import scala.annotation.implicitNotFound
 
-@implicitNotFound("Could not find implicit quoted.Toolbox.\n\nDefault toolbox can be instantiated with:\n  `implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make`\n\n")
+@implicitNotFound("Could not find implicit quoted.Toolbox.\n\nDefault toolbox can be instantiated with:\n  `implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)`\n\n")
 trait Toolbox {
   def run[T](expr: Expr[T]): T
   def show[T](expr: Expr[T]): String
@@ -11,25 +11,12 @@ trait Toolbox {
 
 object Toolbox {
 
-  /** Create a new instance of the toolbox.
-    *
-    * This instance of the toolbox tries to recover the classloader of the application based on
-    * the classloader of the class that call make. This may not always be the correct classloader,
-    * in which case the classloader must be passed explicitly.
-    *
-    * @param settings toolbox settings
-    * @return A new instance of the toolbox
-    */
-  @forceInline def make(implicit settings: Settings): Toolbox = {
-    // Get the name of the class at call site
-    val className = new Throwable().getStackTrace.head.getClassName
-    // We inline to make forName use the classloader of the class at call site
-    val clazz = Class.forName(className)
-    val cl = clazz.getClassLoader
-    make(cl)
-  }
-
   /** Create a new instance of the toolbox using the the classloader of the application.
+    *
+    * Usuage:
+    * ```
+    * implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
+    * ```
     *
     * @param appClassloader classloader of the application that generated the quotes
     * @param settings toolbox settings

sbt-dotty/sbt-test/sbt-dotty/quoted-example-project/src/main/scala/hello/Hello.scala

@@ -5,9 +5,10 @@ import scala.quoted._
 
 object Main {
 
-  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
+  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
 
   def main(args: Array[String]): Unit = {
+
     val square = stagedPower(2)
 
     assert(Math.pow(3, 2) == square(3))

tests/neg-with-compiler/i5941/macro_1.scala

@@ -13,10 +13,9 @@ object Lens {
   }
 
   def impl[S: Type, T: Type](getter: Expr[S => T])(implicit refl: Reflection): Expr[Lens[S, T]] = {
+    implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(this.getClass.getClassLoader)
     import refl._
     import util._
-    implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
-
     // obj.copy(field = value)
     def setterBody(obj: Expr[S], value: Expr[T], field: String): Expr[S] =
       Select.overloaded(obj.unseal, "copy", Nil, NamedArg(field, value.unseal) :: Nil).seal.cast[S]

tests/neg-with-compiler/quote-run-in-macro-1/quoted_1.scala

@@ -3,8 +3,7 @@ import scala.quoted.autolift._
 
 object Macros {
 
-  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
-
+  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
   inline def foo(i: => Int): Int = ${ fooImpl('i) }
   def fooImpl(i: Expr[Int]): Expr[Int] = {
     val y: Int = i.run

tests/neg-with-compiler/quote-run-in-macro-2/quoted_1.scala

@@ -5,7 +5,7 @@ object Macros {
 
   inline def foo(i: => Int): Int = ${ fooImpl('i) }
   def fooImpl(i: Expr[Int]): Expr[Int] = {
-    implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
+    implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
     val y: Int = i.run
     y
   }

tests/neg/tasty-string-interpolator-position-a/Macro_1.scala

@@ -13,7 +13,6 @@ object FIntepolator {
 
   def apply(strCtxExpr: Expr[StringContext], argsExpr: Expr[Seq[Any]])(implicit reflect: Reflection): Expr[String] = {
     import reflect._
-    implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
     error("there are no parts", strCtxExpr.unseal.underlyingArgument.pos)
     '{ ($strCtxExpr).s($argsExpr: _*) }
   }

tests/neg/tasty-string-interpolator-position-b/Macro_1.scala

@@ -10,8 +10,7 @@ object Macro {
 }
 
 object FIntepolator {
-  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
-
+  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
   def apply(strCtxExpr: Expr[StringContext], argsExpr: Expr[Seq[Any]])(implicit reflect: Reflection): Expr[String] = {
     import reflect._
     error("there are no args", argsExpr.unseal.underlyingArgument.pos)

tests/pos-with-compiler/quote-0.scala

@@ -39,7 +39,6 @@ class Test {
     ${ powerCode(3, '{math.sqrt(2.0)}) }
   }
 
-  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
-
+  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
   program.run
 }

tests/pos-with-compiler/quote-assert/quoted_2.scala

@@ -15,7 +15,6 @@ object Test {
     ${ assertImpl('{x != 0}) }
   }
 
-  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make
-
+  implicit val toolbox: scala.quoted.Toolbox = scala.quoted.Toolbox.make(getClass.getClassLoader)
   program.run
 }