Fix link resolving in scaladoc and fix invalid links in docs #18465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #17099 changes with previous link resolver, which fixes #18285, #18444 and brings down
Unable to resolve linkwarnings from 81 to 7.4 more links are fixed manually in
.mdfiles, which leaves us with 3 warnings.Those 3 are references to source code inside
scaladoc.md:https://github.com/lampepfl/dotty/blob/45f633d0667c702fa75efcfda91b434bb72f04dc/docs/_docs/contributing/scaladoc.md?plain=1#L77-L87
Those won't work online anyway (unless we link to github), so we might want change them.