chore: drop old stdlib plugin in favour of internal project #23202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
drop-stdlib-plugin
branch
4 times, most recently
from
8d8e95c to
2775ade
Compare
sjrd
approved these changes
May 23, 2025
Member
Author
|
Both myself and @sjrd have MiMa passing locally. Investigating... |
He-Pin
reviewed
May 26, 2025
| */ | ||
| def swap: Tuple2[T2,T1] = Tuple2(_2, _1) | ||
|
|
||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
seems missing and end line here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recompile scala 2 files that still require the scala 2 compiler (files with
@specialized+AnyVal).We add them manually to the scala 2 jar.
This replaces the old copy-paste system that was less safe.
NOTE: MiMa compares against the jar and not the output folder. This is important as we want to guarantee that the shipped jar is compatible. Also, MiMa doesn't allow to specify multiple output directories as source.