chore: add support for sbt-test in the new build
#23748
Open
+47
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added a commit
that referenced
this pull request
Aug 15, 2025
…nstead of `semver-spec` (#23753) In some scenarios, specifically in cross compilation projects, sbt will complain that `scala-library:2.13.x` and `scala-library:3.x.y` might be imcompatible, as they are both declared `semver-spec`. See en example here: ```scala [error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible: [error] [error] * org.scala-lang:scala-library:3.8.0-RC1-bin-SNAPSHOT (semver-spec) is selected over 2.13.0 [error] +- org.scala-lang:scala3-library_3:3.8.0-RC1-bin-SNAPSHOT (depends on 3.8.0-RC1-bin-SNAPSHOT) [error] +- org.scala-lang.modules:scala-xml_2.13:1.2.0 (depends on 2.13.0) ``` In this PR, we change the version scheme of both `scala-library` and `scalajs-scalalib_2.13` to `always` so that the transition between the old stdlib structure and the new one stay invisible to the users. In the future, when we break binary compatibility (meaning Scala 4), we can revert this PR and have artifacts labeled with `semver-spec` as it will be exactly that scheme. --- The correctness was validated in #23748 locally. [skip ci]
hamzaremmal
force-pushed
the
new-sbt-test
branch
2 times, most recently
from
0341c3f to
9a24c0a
Compare
hamzaremmal
force-pushed
the
new-sbt-test
branch
2 times, most recently
from
e717cd2 to
1a0d946
Compare
hamzaremmal
commented
Oct 7, 2025
Comment on lines
-65
to
-67
| - name: Generate documentation for example project using dotty-sbt | ||
| run: ./project/scripts/sbt "sbt-test/scripted sbt-dotty/scaladoc" | ||
|
|
There was a problem hiding this comment.
We will be running these alongside all the other scripted tests anyways, no need to run them twice.
hamzaremmal
force-pushed
the
new-sbt-test
branch
from
1a0d946 to
c83f49b
Compare
sjrd
approved these changes
Oct 7, 2025
sjrd
reviewed
Oct 7, 2025
hamzaremmal
force-pushed
the
new-sbt-test
branch
from
c83f49b to
6622343
Compare
hamzaremmal
force-pushed
the
new-sbt-test
branch
from
6622343 to
3d55eda
Compare
hamzaremmal
commented
Oct 8, 2025
| run: | | ||
| ./project/scripts/buildScalaBinary | ||
| ./project/scripts/sbt ";scala3-bootstrapped/compile ;sbt-test/scripted scala2-compat/* ;scala3-compiler-bootstrapped/scala3CompilerCoursierTest:test" | ||
| ./project/scripts/sbt ";scala3-bootstrapped/compile ;scala3-bootstrapped/publishLocal ;scala3-compiler-bootstrapped/scala3CompilerCoursierTest:test" |
There was a problem hiding this comment.
sbt-test/scripted had the side effect of publishing the artifacts locally, which is needed by the following scripts. This will be made very clear when removing these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the scripted tests (
sbt-test) to be run using the new stdlib.This PR should fail at the moment as we do not have thescaladocartifacts yet in the build.