Let FreshCaps in field types contribute to class captures #24136
+787
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefix is mapped as a normal type. It determines whether the hidden set allows to add new elements. ThisType and NoPrefix prefixes allow it, other prefixes forbid it. The pathRoot and ccOwner of a FreshCap now depend on the prefix.
Also: add another test that demonstrates some behavior relating to default parameters. Also: Rename a test so that we don't accidentally get the test file. In general, it's a bad idea to use a source file name in the compiler code for a test since we often get the wrong file when loading it into the editor.
Was cap.rd before, which was a left-over of the old model.
Refine the isField test in SymUtils to exclude non-members and phantom symbols
odersky
force-pushed
the
add-fresh-prefix
branch
from
47fc1f9 to
dfcca31
Compare
A fresh in the capture set of a class field now causes a fresh to be added to the capture set of every instance of that class.
odersky
force-pushed
the
add-fresh-prefix
branch
from
dfcca31 to
d2abdfe
Compare
- Drop the assertion and handle the case of empty overlap - At the same time, avoid the empty overlap by taking complete instead of direct footprints. Also: Improve printing of FreshCap prefixes
and a fresh for one of its fields.
Needed for use checking, since if we just take the leftmost prefix we sometimes end up with a `this`.
odersky
force-pushed
the
add-fresh-prefix
branch
from
7e813cd to
a0f1613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fresh in the capture set of a class field now causes a fresh
to be added to the capture set of every instance of that class.
This caused 18 failures in stdlib of which 2 were significant (the rest was deprecated stuff). So far, we make
this compile with the
@caps.unsafe.untrackedCapturesannotation. #24137 explains what would be neededto fix this in a safer way.