add tests for loading rocks config file

Author: fm3

src/main/scala/com/scalableminds/fossildb/db/RocksDBStore.scala

@@ -30,20 +30,20 @@ class RocksDBManager(dataDir: Path, columnFamilies: List[String], optionsFilePat
     }
     val columnFamilyHandles = new util.ArrayList[ColumnFamilyHandle]
     var options = new DBOptions()
-      .setCreateIfMissing(true)
-      .setCreateMissingColumnFamilies(true)
     var cfListRef: mutable.Buffer[ColumnFamilyDescriptor] = mutable.Buffer()
     optionsFilePathOpt.map { optionsFilePath =>
       try {
         org.rocksdb.OptionsUtil.loadOptionsFromFile(optionsFilePath, Env.getDefault, options, cfListRef.asJava)
         logger.info("successfully loaded rocksdb options from " + optionsFilePath)
       } catch {
         case e: Exception => {
-          logger.error("Failed to load rocksdb options from file " + optionsFilePath + ": " + e.getMessage)
-          System.exit(1)
+          throw new Exception("Failed to load rocksdb options from file " + optionsFilePath, e)
         }
       }
     }
+    options = options
+      .setCreateIfMissing(true)
+      .setCreateMissingColumnFamilies(true)
     logger.info("Opening RocksDB at " + dataDir.toAbsolutePath)
     val db = RocksDB.open(
       options,

src/test/scala/com/scalableminds/fossildb/FossilDBSuite.scala

@@ -14,8 +14,8 @@ import org.scalatest.{BeforeAndAfterEach, FlatSpec}
 
 import scala.concurrent.ExecutionContext
 
-class FossilDBSuite extends FlatSpec with BeforeAndAfterEach {
-  val testTempDir = "testData"
+class FossilDBSuite extends FlatSpec with BeforeAndAfterEach with TestHelpers {
+  val testTempDir = "testData1"
   val dataDir = Paths.get(testTempDir, "data")
   val backupDir = Paths.get(testTempDir, "backup")
 
@@ -35,13 +35,6 @@ class FossilDBSuite extends FlatSpec with BeforeAndAfterEach {
   val anotherKey = "anotherKey"
   val aThirdKey = "aThirdKey"
 
-  private def deleteRecursively(file: File): Unit = {
-    if (file.isDirectory)
-      file.listFiles.foreach(deleteRecursively)
-    if (file.exists && !file.delete)
-      throw new Exception(s"Unable to delete ${file.getAbsolutePath}")
-  }
-
   override def beforeEach = {
     deleteRecursively(new File(testTempDir))
     new File(testTempDir).mkdir()

src/test/scala/com/scalableminds/fossildb/RocksOptionsSuite.scala

@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2011-2018 scalable minds UG (haftungsbeschränkt) & Co. KG. <http://scm.io>
+ */
+package com.scalableminds.fossildb
+
+import java.io.File
+import java.nio.file.Paths
+
+import com.scalableminds.fossildb.db.StoreManager
+import org.rocksdb.{ColumnFamilyDescriptor, DBOptions, Env}
+import org.scalatest.{BeforeAndAfterEach, FlatSpec}
+
+import scala.collection.mutable
+import scala.collection.JavaConverters._
+import scala.io.Source
+
+class RocksOptionsSuite extends FlatSpec with BeforeAndAfterEach with TestHelpers {
+
+  val testTempDir = "testData2"
+  val dataDir = Paths.get(testTempDir, "data")
+  val backupDir = Paths.get(testTempDir, "backup")
+
+  val collectionA = "collectionA"
+  val collectionB = "collectionB"
+
+  val columnFamilies = List(collectionA, collectionB)
+
+
+
+  override def beforeEach = {
+    deleteRecursively(new File(testTempDir))
+    new File(testTempDir).mkdir()
+  }
+
+  override def afterEach = {
+    deleteRecursively(new File(testTempDir))
+  }
+
+
+
+  "Initializing the StoreManager" should "load and use a specified config file" in {
+    val file = new File(testTempDir, "testConfig.ini")
+    writeToFile(file, "[Version]\n  rocksdb_version=5.11.3\n  options_file_version=1.1\n\n[DBOptions]\n  stats_dump_period_sec=700\n\n[CFOptions \"default\"]\n\n")
+
+    val storeManager = new StoreManager(dataDir, backupDir, columnFamilies, Some(file.getPath))
+
+    var options = new DBOptions()
+      .setStatsDumpPeriodSec(100)
+    var cfListRef: mutable.Buffer[ColumnFamilyDescriptor] = mutable.Buffer()
+    // if successful, the rocksdb writes the loaded options to a file that can then be retreived with loadLatestOptions
+    // we test that that one now includes the value 700 from the file above, rather than the 100 specified as a default
+    org.rocksdb.OptionsUtil.loadLatestOptions(dataDir.toString, Env.getDefault, options, cfListRef.asJava)
+    assert(options.statsDumpPeriodSec() == 700)
+    storeManager.close
+  }
+
+  it should "fail if specified config file does not exist" in {
+    assertThrows[Exception] {
+      new StoreManager(dataDir, backupDir, columnFamilies, Some("nonExistingPath.ini"))
+    }
+  }
+
+  it should "fail if specified config file is invalid" in {
+    val file = new File(testTempDir, "testConfig.ini")
+    writeToFile(file, "[Version]\n  rocksdb_version=5.11.3\n  options_file_version=1.1\n\n[DBOptions]\n  stats_dump_period_sec=700")
+
+    assertThrows[Exception] {
+      new StoreManager(dataDir, backupDir, columnFamilies, Some(file.getPath))
+    }
+  }
+
+
+
+}

src/test/scala/com/scalableminds/fossildb/TestHelpers.scala

@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2011-2018 scalable minds UG (haftungsbeschränkt) & Co. KG. <http://scm.io>
+ */
+package com.scalableminds.fossildb
+
+import java.io.{BufferedWriter, File, FileWriter}
+
+trait TestHelpers {
+
+  protected def deleteRecursively(file: File): Unit = {
+    if (file.isDirectory)
+      file.listFiles.foreach(deleteRecursively)
+    if (file.exists && !file.delete)
+      throw new Exception(s"Unable to delete ${file.getAbsolutePath}")
+  }
+
+  protected def writeToFile(file: File, content: String): Unit = {
+    val bw = new BufferedWriter(new FileWriter(file))
+    bw.write(content)
+    bw.close()
+  }
+
+}