Change default dimension_separator for Zarr2 (#1274)

* Change default dimension_separator for Zarr2

* changelog

* fix copytree

Author: normanrz

webknossos/Changelog.md

@@ -17,6 +17,7 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
 ### Added
 
 ### Changed
+- Changed the default dimension separator for Zarr 2 arrays from `.` to `/`. [#1274](https://github.com/scalableminds/webknossos-libs/pull/1274)
 
 ### Fixed
 

webknossos/webknossos/dataset/_array.py

@@ -842,7 +842,7 @@ def create(cls, path: Path, array_info: ArrayInfo) -> "Zarr2Array":
                         else None
                     ),
                     "filters": None,
-                    "dimension_separator": ".",
+                    "dimension_separator": "/",
                 },
                 "create": True,
             }

webknossos/webknossos/utils.py

@@ -324,7 +324,11 @@ def _walk(path: Path) -> Iterator[Path]:
 
 def copytree(in_path: Path, out_path: Path) -> None:
     def _walk(path: Path, base_path: Path) -> Iterator[Tuple[Path, Tuple[str, ...]]]:
-        yield (path, tuple(p for p in path.parts if p not in base_path.parts))
+        # base_path.parts is a prefix of path.parts; strip it
+        assert len(path.parts) >= len(base_path.parts)
+        assert path.parts[: len(base_path.parts)] == base_path.parts
+        yield (path, path.parts[len(base_path.parts) :])
+
         if path.is_dir():
             for p in path.iterdir():
                 yield from _walk(p, base_path)