FinishUpload: stop retrying on error (#702)

fm3 · web-flow · commit 73648026c34c · 2022-04-20T14:42:46.000+02:00
* FinishUpload: stop retrying on error

* changelog
diff --git a/webknossos/Changelog.md b/webknossos/Changelog.md
@@ -20,6 +20,8 @@ For upgrade instructions, please check the respective *Breaking Changes* section
 
 ### Fixed
 
+- Fixed a bug where the server’s error message during dataset upload was not displayed to the user. [#702](https://github.com/scalableminds/webknossos-libs/pull/702)
+
 
 ## [0.9.19](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.9.19) - 2022-04-11
 [Commits](https://github.com/scalableminds/webknossos-libs/compare/v0.9.18...v0.9.19)
diff --git a/webknossos/webknossos/client/_upload_dataset.py b/webknossos/webknossos/client/_upload_dataset.py
@@ -174,9 +174,8 @@ def upload_dataset(
                 }
             ),
         )
-        if response.status_code == 200:
+        if response.status_code == 200 or response.status_code == 400:
             break
-    else:
-        assert response.status_code == 200, response
+    assert response.status_code == 200, response
 
     return f"{context.url}/datasets/{context.organization_id}/{new_dataset_name}/view"

Original file line number	Diff line number	Diff line change
`@@ -174,9 +174,8 @@ def upload_dataset(`
`174`	`174`	`}`
`175`	`175`	`),`
`176`	`176`	`)`
`177`		`- if response.status_code == 200:`
	`177`	`+ if response.status_code == 200 or response.status_code == 400:`
`178`	`178`	`break`
`179`		`- else:`
`180`		`- assert response.status_code == 200, response`
	`179`	`+ assert response.status_code == 200, response`
`181`	`180`
`182`	`181`	`return f"{context.url}/datasets/{context.organization_id}/{new_dataset_name}/view"`