Skip to content

Commit 88f499e

Browse files
fm3jstriebel
andauthored
No equal sign in generated layer names (#867)
Co-authored-by: Jonathan Striebel <[email protected]>
1 parent 2c06e84 commit 88f499e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

webknossos/Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ For upgrade instructions, please check the respective *Breaking Changes* section
1818
- Added `read_only` parameter for `annotation.temporary_volume_layer_copy`. [#866](https://github.com/scalableminds/webknossos-libs/pull/866)
1919

2020
### Changed
21+
- in Dataset.layer_from_images, layer names generated from multiple input image channels no longer contain equal signs, yielding better url safety. [#867](https://github.com/scalableminds/webknossos-libs/pull/867)
2122

2223
### Fixed
2324
- Fixed a bug where some czi, dm3, dm4 images could not be converted to wkw due to a too-strict check. [#865](https://github.com/scalableminds/webknossos-libs/pull/865)

webknossos/webknossos/dataset/dataset.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,15 +1088,15 @@ def add_layer_from_images(
10881088
# "timepoint": [0, 1],
10891089
# }
10901090
# suffix_with_pims_open_kwargs_per_layer = {
1091-
# "__channel=0_timepoint=0", {"channel": 0, "timepoint": 0},
1092-
# "__channel=0_timepoint=1", {"channel": 0, "timepoint": 1},
1093-
# "__channel=0_timepoint=2", {"channel": 0, "timepoint": 2},
1091+
# "__channel0_timepoint0", {"channel": 0, "timepoint": 0},
1092+
# "__channel0_timepoint1", {"channel": 0, "timepoint": 1},
1093+
# "__channel0_timepoint2", {"channel": 0, "timepoint": 2},
10941094
# …,
1095-
# "__channel=1_timepoint=0", {"channel": 1, "timepoint": 0},
1095+
# "__channel1_timepoint0", {"channel": 1, "timepoint": 0},
10961096
# …,
10971097
# }
10981098
suffix_with_pims_open_kwargs_per_layer = {
1099-
"__" + "_".join(f"{k}={v}" for k, v in sorted(pairs)): dict(pairs)
1099+
"__" + "_".join(f"{k}{v}" for k, v in sorted(pairs)): dict(pairs)
11001100
for pairs in product(
11011101
*(
11021102
[(key, value) for value in values]

0 commit comments

Comments
 (0)