Skip to content

Commit cf27056

Browse files
Make folder id parameter of announce upload route optional according to beackend route (#1313)
* make folder id parameter of announce upload route optional according to beackend route * add changelog entry * Update webknossos/Changelog.md Co-authored-by: Mark Bader <[email protected]> --------- Co-authored-by: Mark Bader <[email protected]>
1 parent bf60ec0 commit cf27056

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

webknossos/Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
1717
### Added
1818

1919
### Changed
20+
- Made the folder_id parameter of `Dataset.announce_manual_upload` optional. [#1313](https://github.com/scalableminds/webknossos-libs/pull/1313)
2021

2122
### Fixed
2223

webknossos/webknossos/client/api_client/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class ApiDatasetAnnounceUpload:
131131
dataset_name: str
132132
organization: str
133133
initial_team_ids: list[str]
134-
folder_id: str
134+
folder_id: str | None
135135
require_unique_name: bool
136136

137137

webknossos/webknossos/dataset/dataset.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ def announce_manual_upload(
465465
dataset_name: str,
466466
organization: str,
467467
initial_team_ids: list[str],
468-
folder_id: str | RemoteFolder,
468+
folder_id: str | RemoteFolder | None,
469469
require_unique_name: bool = False,
470470
token: str | None = None,
471471
) -> tuple[str, str]:
@@ -478,7 +478,8 @@ def announce_manual_upload(
478478
dataset_name: Name for the new dataset
479479
organization: Organization ID to upload to
480480
initial_team_ids: List of team IDs to grant initial access
481-
folder_id: ID of folder where dataset should be placed
481+
folder_id: Optional ID of folder where dataset should be placed
482+
require_unique_name: Whether to make request fail in case a dataset with the name already exists
482483
token: Optional authentication token
483484
484485
Note:

0 commit comments

Comments
 (0)